From: Peter Zijlstra <peterz@infradead.org>
To: Patrick Bellasi <patrick.bellasi@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Paul Turner <pjt@google.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Juri Lelli <juri.lelli@redhat.com>, Todd Kjos <tkjos@android.com>,
Joel Fernandes <joelaf@google.com>,
Steve Muckle <smuckle@google.com>
Subject: Re: [PATCH v5 3/4] sched/cpufreq_schedutil: use util_est for OPP selection
Date: Wed, 7 Mar 2018 11:12:14 +0100 [thread overview]
Message-ID: <20180307101214.GI25201@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180222170153.673-4-patrick.bellasi@arm.com>
On Thu, Feb 22, 2018 at 05:01:52PM +0000, Patrick Bellasi wrote:
> static inline unsigned long cpu_util_cfs(struct rq *rq)
> {
> + if (!sched_feat(UTIL_EST))
> + return READ_ONCE(rq->cfs.avg.util_avg);
> +
> + return max_t(unsigned long,
> + READ_ONCE(rq->cfs.avg.util_avg),
> + READ_ONCE(rq->cfs.avg.util_est.enqueued));
> }
static inline unsigned long cpu_util_cfs(struct rq *rq)
{
unsigned long util = READ_ONCE(rq->cfs.avg.util_avg);
if (sched_feat(UTIL_EST)) {
util = max_t(unsigned long, util,
READ_ONCE(rq->cfs.avg.util_est.enqueued));
}
return util;
}
Seems like a more readable variant.
next prev parent reply other threads:[~2018-03-07 10:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 17:01 [PATCH v5 0/4] Utilization estimation (util_est) for FAIR tasks Patrick Bellasi
2018-02-22 17:01 ` [PATCH v5 1/4] sched/fair: add util_est on top of PELT Patrick Bellasi
2018-03-01 17:42 ` Patrick Bellasi
2018-03-06 18:56 ` Peter Zijlstra
2018-03-07 12:32 ` Patrick Bellasi
2018-03-06 18:58 ` Peter Zijlstra
2018-03-07 9:39 ` Peter Zijlstra
2018-03-07 15:37 ` Patrick Bellasi
2018-03-07 11:31 ` Patrick Bellasi
2018-03-07 12:24 ` Peter Zijlstra
2018-03-07 15:24 ` Patrick Bellasi
2018-03-07 17:35 ` Peter Zijlstra
2018-03-06 19:02 ` Peter Zijlstra
2018-03-07 11:47 ` Patrick Bellasi
2018-03-07 12:26 ` Peter Zijlstra
2018-03-07 15:16 ` Patrick Bellasi
2018-02-22 17:01 ` [PATCH v5 2/4] sched/fair: use util_est in LB and WU paths Patrick Bellasi
2018-02-22 17:01 ` [PATCH v5 3/4] sched/cpufreq_schedutil: use util_est for OPP selection Patrick Bellasi
2018-02-26 4:04 ` Viresh Kumar
2018-03-07 10:12 ` Peter Zijlstra [this message]
2018-02-22 17:01 ` [PATCH v5 4/4] sched/fair: update util_est only on util_avg updates Patrick Bellasi
2018-03-01 17:46 ` Patrick Bellasi
2018-03-07 10:38 ` Peter Zijlstra
2018-03-08 9:15 ` Peter Zijlstra
2018-03-08 9:48 ` Peter Zijlstra
2018-03-08 10:37 ` Patrick Bellasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307101214.GI25201@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dietmar.eggemann@arm.com \
--cc=joelaf@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=pjt@google.com \
--cc=rafael.j.wysocki@intel.com \
--cc=smuckle@google.com \
--cc=tkjos@android.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox