* [PATCH] ACPI / PM: Blacklist Low Power S0 Idle _DSM for ThinkPad X1 Tablet(2016)
@ 2018-04-10 15:07 Yu Chen
2018-04-24 10:06 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Yu Chen @ 2018-04-10 15:07 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown
Cc: linux-acpi, linux-kernel, Robin Lee, Hans de Goede, Chen Yu
From: Chen Yu <yu.c.chen@intel.com>
ThinkPad X1 Tablet(2016) is reported to have issues with
the Low Power S0 Idle _DSM interface and since this machine
model generally can do ACPI S3 just fine, and user would
like to use S3 as default sleep model, add a blacklist
entry to disable that interface for ThinkPad X1 Tablet(2016).
Reported-and-tested-by: Robin Lee <robinlee.sysu@gmail.com>
Signed-off-by: Chen Yu <yu.c.chen@intel.com>
---
drivers/acpi/sleep.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
index 46cde0912762..465f33aa0bd8 100644
--- a/drivers/acpi/sleep.c
+++ b/drivers/acpi/sleep.c
@@ -364,6 +364,19 @@ static const struct dmi_system_id acpisleep_dmi_table[] __initconst = {
DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),
},
},
+ /*
+ * https://bugzilla.kernel.org/show_bug.cgi?id=199057
+ * ThinkPad X1 Tablet(2016) cannot do suspend-to-idle using the Low Power
+ * S0 Idle firmware interface.
+ */
+ {
+ .callback = init_no_lps0,
+ .ident = "ThinkPad X1 Tablet(2016)",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "20GGA00L00"),
+ },
+ },
{},
};
--
2.13.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ACPI / PM: Blacklist Low Power S0 Idle _DSM for ThinkPad X1 Tablet(2016)
2018-04-10 15:07 [PATCH] ACPI / PM: Blacklist Low Power S0 Idle _DSM for ThinkPad X1 Tablet(2016) Yu Chen
@ 2018-04-24 10:06 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2018-04-24 10:06 UTC (permalink / raw)
To: Yu Chen; +Cc: Len Brown, linux-acpi, linux-kernel, Robin Lee, Hans de Goede
On Tuesday, April 10, 2018 5:07:51 PM CEST Yu Chen wrote:
> From: Chen Yu <yu.c.chen@intel.com>
>
> ThinkPad X1 Tablet(2016) is reported to have issues with
> the Low Power S0 Idle _DSM interface and since this machine
> model generally can do ACPI S3 just fine, and user would
> like to use S3 as default sleep model, add a blacklist
> entry to disable that interface for ThinkPad X1 Tablet(2016).
>
> Reported-and-tested-by: Robin Lee <robinlee.sysu@gmail.com>
> Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> ---
> drivers/acpi/sleep.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> index 46cde0912762..465f33aa0bd8 100644
> --- a/drivers/acpi/sleep.c
> +++ b/drivers/acpi/sleep.c
> @@ -364,6 +364,19 @@ static const struct dmi_system_id acpisleep_dmi_table[] __initconst = {
> DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),
> },
> },
> + /*
> + * https://bugzilla.kernel.org/show_bug.cgi?id=199057
> + * ThinkPad X1 Tablet(2016) cannot do suspend-to-idle using the Low Power
> + * S0 Idle firmware interface.
> + */
> + {
> + .callback = init_no_lps0,
> + .ident = "ThinkPad X1 Tablet(2016)",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "20GGA00L00"),
> + },
> + },
> {},
> };
>
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-24 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-10 15:07 [PATCH] ACPI / PM: Blacklist Low Power S0 Idle _DSM for ThinkPad X1 Tablet(2016) Yu Chen
2018-04-24 10:06 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox