* [PATCH] ACPI: add missing newline to printk
@ 2018-04-10 17:10 Laszlo Toth
2018-05-09 9:54 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Laszlo Toth @ 2018-04-10 17:10 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown; +Cc: linux-acpi, linux-kernel
...and restore reverse xmas tree while at it.
Signed-off-by: Laszlo Toth <laszlth@gmail.com>
---
drivers/acpi/reboot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/reboot.c b/drivers/acpi/reboot.c
index 71769fd..6fa9c2a 100644
--- a/drivers/acpi/reboot.c
+++ b/drivers/acpi/reboot.c
@@ -8,8 +8,8 @@ void acpi_reboot(void)
{
struct acpi_generic_address *rr;
struct pci_bus *bus0;
- u8 reset_value;
unsigned int devfn;
+ u8 reset_value;
if (acpi_disabled)
return;
@@ -40,7 +40,7 @@ void acpi_reboot(void)
/* Form PCI device/function pair. */
devfn = PCI_DEVFN((rr->address >> 32) & 0xffff,
(rr->address >> 16) & 0xffff);
- printk(KERN_DEBUG "Resetting with ACPI PCI RESET_REG.");
+ printk(KERN_DEBUG "Resetting with ACPI PCI RESET_REG.\n");
/* Write the value that resets us. */
pci_bus_write_config_byte(bus0, devfn,
(rr->address & 0xffff), reset_value);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ACPI: add missing newline to printk
2018-04-10 17:10 [PATCH] ACPI: add missing newline to printk Laszlo Toth
@ 2018-05-09 9:54 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2018-05-09 9:54 UTC (permalink / raw)
To: Laszlo Toth; +Cc: Len Brown, linux-acpi, linux-kernel
On Tuesday, April 10, 2018 7:10:38 PM CEST Laszlo Toth wrote:
> ...and restore reverse xmas tree while at it.
>
> Signed-off-by: Laszlo Toth <laszlth@gmail.com>
> ---
> drivers/acpi/reboot.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/reboot.c b/drivers/acpi/reboot.c
> index 71769fd..6fa9c2a 100644
> --- a/drivers/acpi/reboot.c
> +++ b/drivers/acpi/reboot.c
> @@ -8,8 +8,8 @@ void acpi_reboot(void)
> {
> struct acpi_generic_address *rr;
> struct pci_bus *bus0;
> - u8 reset_value;
> unsigned int devfn;
> + u8 reset_value;
>
> if (acpi_disabled)
> return;
> @@ -40,7 +40,7 @@ void acpi_reboot(void)
> /* Form PCI device/function pair. */
> devfn = PCI_DEVFN((rr->address >> 32) & 0xffff,
> (rr->address >> 16) & 0xffff);
> - printk(KERN_DEBUG "Resetting with ACPI PCI RESET_REG.");
> + printk(KERN_DEBUG "Resetting with ACPI PCI RESET_REG.\n");
> /* Write the value that resets us. */
> pci_bus_write_config_byte(bus0, devfn,
> (rr->address & 0xffff), reset_value);
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] acpi: add missing newline to printk
@ 2012-11-02 16:51 Cesar Eduardo Barros
2012-11-02 20:06 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Cesar Eduardo Barros @ 2012-11-02 16:51 UTC (permalink / raw)
To: linux-acpi
Cc: Len Brown, Rafael J. Wysocki, linux-kernel, trivial,
Cesar Eduardo Barros, Lin Ming, Len Brown
The missing newline causes messages like this on dmesg:
[ 2.578212] ACPI: Invalid Power Resource to register!<5>[2.578456] ...
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Len Brown <len.brown@intel.com>
Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
---
drivers/acpi/power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
index 40e38a0..7db61b8 100644
--- a/drivers/acpi/power.c
+++ b/drivers/acpi/power.c
@@ -473,7 +473,7 @@ int acpi_power_resource_register_device(struct device *dev, acpi_handle handle)
return ret;
no_power_resource:
- printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!");
+ printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!\n");
return -ENODEV;
}
EXPORT_SYMBOL_GPL(acpi_power_resource_register_device);
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] acpi: add missing newline to printk
2012-11-02 16:51 [PATCH] acpi: " Cesar Eduardo Barros
@ 2012-11-02 20:06 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2012-11-02 20:06 UTC (permalink / raw)
To: Cesar Eduardo Barros
Cc: linux-acpi, Len Brown, linux-kernel, trivial, Lin Ming, Len Brown
On Friday, November 02, 2012 02:51:18 PM Cesar Eduardo Barros wrote:
> The missing newline causes messages like this on dmesg:
>
> [ 2.578212] ACPI: Invalid Power Resource to register!<5>[2.578456] ...
>
> Cc: Lin Ming <ming.m.lin@intel.com>
> Cc: Len Brown <len.brown@intel.com>
> Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
An equivalent patch has been applied already.
Thanks,
Rafael
> ---
> drivers/acpi/power.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
> index 40e38a0..7db61b8 100644
> --- a/drivers/acpi/power.c
> +++ b/drivers/acpi/power.c
> @@ -473,7 +473,7 @@ int acpi_power_resource_register_device(struct device *dev, acpi_handle handle)
> return ret;
>
> no_power_resource:
> - printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!");
> + printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!\n");
> return -ENODEV;
> }
> EXPORT_SYMBOL_GPL(acpi_power_resource_register_device);
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-09 9:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-10 17:10 [PATCH] ACPI: add missing newline to printk Laszlo Toth
2018-05-09 9:54 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2012-11-02 16:51 [PATCH] acpi: " Cesar Eduardo Barros
2012-11-02 20:06 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox