[PATCH v2] uio: Change return type to vm_fault_t

[PATCH v2] uio: Change return type to vm_fault_t

[Souptick Joarder]

Use new return type vm_fault_t for fault handler
in struct vm_operations_struct. For now, this is
just documenting that the function returns a 
VM_FAULT value rather than an errno.  Once all
instances are converted, vm_fault_t will become
a distinct type.

Reference commit id->
1c8f422059ae5da07db7406ab916203f9417e396

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
---
v2: Modified the change log

 drivers/uio/uio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index fd48483..d9235f3 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -597,7 +597,7 @@ static int uio_find_mem_index(struct vm_area_struct *vma)
 	return -1;
 }

-static int uio_vma_fault(struct vm_fault *vmf)
+static vm_fault_t uio_vma_fault(struct vm_fault *vmf)
 {
 	struct uio_device *idev = vmf->vma->vm_private_data;
 	struct page *page;
--
1.9.1

Re: [PATCH v2] uio: Change return type to vm_fault_t

[Greg KH]

On Mon, Apr 16, 2018 at 08:24:40PM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for fault handler
> in struct vm_operations_struct. For now, this is
> just documenting that the function returns a 
> VM_FAULT value rather than an errno.  Once all
> instances are converted, vm_fault_t will become
> a distinct type.

Odd line length to wrap at, your editor should have told you to use 72
columns, right?

> Reference commit id->
> 1c8f422059ae5da07db7406ab916203f9417e396

1c8f422059ae ("mm: change return type to vm_fault_t")

Is the "canonical" way to reference git commit ids, it's easy to set up
an alias for this:
	alias gsr='git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"'

> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
> ---
> v2: Modified the change log

3rd time's the charm?

thanks,

greg k-h

Re: [PATCH v2] uio: Change return type to vm_fault_t

[Souptick Joarder]

On Mon, Apr 16, 2018 at 8:56 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Apr 16, 2018 at 08:24:40PM +0530, Souptick Joarder wrote:
>> Use new return type vm_fault_t for fault handler
>> in struct vm_operations_struct. For now, this is
>> just documenting that the function returns a
>> VM_FAULT value rather than an errno.  Once all
>> instances are converted, vm_fault_t will become
>> a distinct type.
>
> Odd line length to wrap at, your editor should have told you to use 72
> columns, right?

Not clear about this.