From: Dan Carpenter <dan.carpenter@oracle.com>
To: Liam Girdwood <lgirdwood@gmail.com>, Lee Jones <lee.jones@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] regulator: ab8500: tidy ab8500_regulator_get_mode()
Date: Thu, 19 Apr 2018 13:08:28 +0300 [thread overview]
Message-ID: <20180419100828.GA10724@mwanda> (raw)
The indenting here is confusing.
Also we don't check "ret". That isn't likely to cause a runtime issue
because if it fails here fails then we'd probably return -EINVAL at the
end anyway. But it does introduce a static checker warning since "val"
is only inititialized on the success path.
drivers/regulator/ab8500.c:429 ab8500_regulator_get_mode()
error: uninitialized symbol 'val'.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
index 83dba3fbfe0c..4fab417f1803 100644
--- a/drivers/regulator/ab8500.c
+++ b/drivers/regulator/ab8500.c
@@ -425,7 +425,10 @@ static unsigned int ab8500_regulator_get_mode(struct regulator_dev *rdev)
if (info->mode_mask) {
/* Dedicated register for handling mode */
ret = abx500_get_register_interruptible(info->dev,
- info->mode_bank, info->mode_reg, &val);
+ info->mode_bank,
+ info->mode_reg, &val);
+ if (ret)
+ return ret;
val = val & info->mode_mask;
val_normal = info->mode_val_normal;
next reply other threads:[~2018-04-19 10:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 10:08 Dan Carpenter [this message]
2018-04-20 8:12 ` [PATCH] regulator: ab8500: tidy ab8500_regulator_get_mode() Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419100828.GA10724@mwanda \
--to=dan.carpenter@oracle.com \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox