From: Lee Jones <lee.jones@linaro.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] regulator: ab8500: tidy ab8500_regulator_get_mode()
Date: Fri, 20 Apr 2018 09:12:46 +0100 [thread overview]
Message-ID: <20180420081246.zos5mblrna2bsj3l@dell> (raw)
In-Reply-To: <20180419100828.GA10724@mwanda>
On Thu, 19 Apr 2018, Dan Carpenter wrote:
> The indenting here is confusing.
>
> Also we don't check "ret". That isn't likely to cause a runtime issue
> because if it fails here fails then we'd probably return -EINVAL at the
> end anyway. But it does introduce a static checker warning since "val"
> is only inititialized on the success path.
>
> drivers/regulator/ab8500.c:429 ab8500_regulator_get_mode()
> error: uninitialized symbol 'val'.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2018-04-20 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 10:08 [PATCH] regulator: ab8500: tidy ab8500_regulator_get_mode() Dan Carpenter
2018-04-20 8:12 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420081246.zos5mblrna2bsj3l@dell \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox