From: Steven Rostedt <rostedt@goodmis.org>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Theodore Ts'o <tytso@mit.edu>, Petr Mladek <pmladek@suse.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] vsprintf: Remove incorrect EXPORT_SYMBOL
Date: Mon, 9 Jul 2018 22:12:14 -0400 [thread overview]
Message-ID: <20180709221214.167e0ed0@vmware.local.home> (raw)
In-Reply-To: <20180710002519.5044-3-me@tobin.cc>
On Tue, 10 Jul 2018 10:25:18 +1000
"Tobin C. Harding" <me@tobin.cc> wrote:
> Recently boot variable 'debug_boot_weak_hash' was added (by me). In a
> classic case of cargo cult programming the novice developer added a
> macro call to EXPORT_SYMBOL(). This is wrong and was pointed out on
> LKML. As pointed out EXPORT_SYMBOL() cannot be used on static
> variables.
>
> Remove incorrect usage of macro EXPORT_SYMBOL()
>
> Fixes: bfe80ed3d7c76 ("vsprintf: add command line option debug_boot_weak_hash")
> Signed-off-by: Tobin C. Harding <me@tobin.cc>
Revieved-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Hmm, not sure if Ted rebases his trees or not, but if he does, he could
also fold this into that commit.
-- Steve
> ---
> lib/vsprintf.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index cdc2c355dff5..fe834a201f3d 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -1655,7 +1655,6 @@ static DEFINE_STATIC_KEY_TRUE(not_filled_random_ptr_key);
>
> /* Make pointers available for printing early in the boot sequence. */
> static int debug_boot_weak_hash __ro_after_init;
> -EXPORT_SYMBOL(debug_boot_weak_hash);
>
> static int __init debug_boot_weak_hash_enable(char *str)
> {
next prev parent reply other threads:[~2018-07-10 2:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 0:25 [PATCH 0/3] fix: enable early printing of hashed pointers Tobin C. Harding
2018-07-10 0:25 ` [PATCH 1/3] random: Remove unnecessary cast Tobin C. Harding
2018-07-10 2:06 ` Steven Rostedt
2018-07-10 0:25 ` [PATCH 2/3] vsprintf: Remove incorrect EXPORT_SYMBOL Tobin C. Harding
2018-07-10 2:12 ` Steven Rostedt [this message]
2018-07-10 0:25 ` [PATCH 3/3] docs: Fix docs for boot parameter debug_boot_weak_hash Tobin C. Harding
2018-07-10 2:14 ` Steven Rostedt
2018-07-10 2:07 ` [PATCH 0/3] fix: enable early printing of hashed pointers Steven Rostedt
2018-07-10 2:59 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709221214.167e0ed0@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox