public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Tobin C. Harding" <me@tobin.cc>
To: Theodore Ts'o <tytso@mit.edu>
Cc: "Tobin C. Harding" <me@tobin.cc>, Petr Mladek <pmladek@suse.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] vsprintf: Remove incorrect EXPORT_SYMBOL
Date: Tue, 10 Jul 2018 10:25:18 +1000	[thread overview]
Message-ID: <20180710002519.5044-3-me@tobin.cc> (raw)
In-Reply-To: <20180710002519.5044-1-me@tobin.cc>

Recently boot variable 'debug_boot_weak_hash' was added (by me).  In a
classic case of cargo cult programming the novice developer added a
macro call to EXPORT_SYMBOL().  This is wrong and was pointed out on
LKML.  As pointed out EXPORT_SYMBOL() cannot be used on static
variables.

Remove incorrect usage of macro EXPORT_SYMBOL()

Fixes: bfe80ed3d7c76 ("vsprintf: add command line option debug_boot_weak_hash")
Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
 lib/vsprintf.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index cdc2c355dff5..fe834a201f3d 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1655,7 +1655,6 @@ static DEFINE_STATIC_KEY_TRUE(not_filled_random_ptr_key);
 
 /* Make pointers available for printing early in the boot sequence. */
 static int debug_boot_weak_hash __ro_after_init;
-EXPORT_SYMBOL(debug_boot_weak_hash);
 
 static int __init debug_boot_weak_hash_enable(char *str)
 {
-- 
2.17.1


  parent reply	other threads:[~2018-07-10  0:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-10  0:25 [PATCH 0/3] fix: enable early printing of hashed pointers Tobin C. Harding
2018-07-10  0:25 ` [PATCH 1/3] random: Remove unnecessary cast Tobin C. Harding
2018-07-10  2:06   ` Steven Rostedt
2018-07-10  0:25 ` Tobin C. Harding [this message]
2018-07-10  2:12   ` [PATCH 2/3] vsprintf: Remove incorrect EXPORT_SYMBOL Steven Rostedt
2018-07-10  0:25 ` [PATCH 3/3] docs: Fix docs for boot parameter debug_boot_weak_hash Tobin C. Harding
2018-07-10  2:14   ` Steven Rostedt
2018-07-10  2:07 ` [PATCH 0/3] fix: enable early printing of hashed pointers Steven Rostedt
2018-07-10  2:59   ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180710002519.5044-3-me@tobin.cc \
    --to=me@tobin.cc \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox