From: Ming Lei <ming.lei@redhat.com>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: axboe@kernel.dk, bart.vanassche@wdc.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] blk-mq: clean up the hctx restart
Date: Tue, 31 Jul 2018 12:58:06 +0800 [thread overview]
Message-ID: <20180731045805.GE15701@ming.t460p> (raw)
In-Reply-To: <1533009735-2221-1-git-send-email-jianchao.w.wang@oracle.com>
On Tue, Jul 31, 2018 at 12:02:15PM +0800, Jianchao Wang wrote:
> Currently, we will always set SCHED_RESTART whenever there are
> requests in hctx->dispatch, then when request is completed and
> freed the hctx queues will be restarted to avoid IO hang. This
> is unnecessary most of time. Especially when there are lots of
> LUNs attached to one host, the RR restart loop could be very
> expensive.
The big RR restart loop has been killed in the following commit:
commit 97889f9ac24f8d2fc8e703ea7f80c162bab10d4d
Author: Ming Lei <ming.lei@redhat.com>
Date: Mon Jun 25 19:31:48 2018 +0800
blk-mq: remove synchronize_rcu() from blk_mq_del_queue_tag_set()
Thanks,
Ming
next prev parent reply other threads:[~2018-07-31 4:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 4:02 [RFC] blk-mq: clean up the hctx restart Jianchao Wang
2018-07-31 4:58 ` Ming Lei [this message]
2018-07-31 5:19 ` jianchao.wang
2018-07-31 6:16 ` Ming Lei
2018-08-01 2:17 ` jianchao.wang
2018-08-01 8:58 ` Ming Lei
2018-08-01 13:37 ` jianchao.wang
2018-08-02 10:39 ` Ming Lei
2018-08-02 15:52 ` Bart Van Assche
2018-08-02 16:58 ` Ming Lei
2018-08-02 17:08 ` Bart Van Assche
2018-08-02 17:17 ` Ming Lei
2018-08-02 17:24 ` Bart Van Assche
2018-08-03 0:35 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731045805.GE15701@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox