public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"jianchao.w.wang@oracle.com" <jianchao.w.wang@oracle.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [RFC] blk-mq: clean up the hctx restart
Date: Fri, 3 Aug 2018 01:17:24 +0800	[thread overview]
Message-ID: <20180802171723.GD8928@ming.t460p> (raw)
In-Reply-To: <7c933e7e60831f985297d8cc5a540171fc921f44.camel@wdc.com>

On Thu, Aug 02, 2018 at 05:08:55PM +0000, Bart Van Assche wrote:
> On Fri, 2018-08-03 at 00:58 +0800, Ming Lei wrote:
> > And about the situations you mentioned, no any special as normal cases
> > or thousands of LUNs. Just a batch of queues are waken up from one
> > single wait queue(sbq_wait_state), and inside each wait queue, queues
> > are handled actually in FIFO order.
> > 
> > Or what is your expected ideal behaviour about fairness?
> 
> Hello Ming,
> 
> What I expect is if the number of LUNs is really large that all LUNs are treated
> equally. Unless someone can set up a test that demonstrates that this is still

Some of idle LUNs shouldn't be treated equally as other LUNs which need
to serve.  

Also as I mentioned, the original RR style isn't better than the new
way actually, since now we handle queues in sort of FIFO style, thanks
wait queue.

Not mentioning big CPU utilization is consumed unnecessarily for iterating
over all queues even though there is only one active queue, is this fair from
system view?

Thanks,
Ming

  reply	other threads:[~2018-08-02 17:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31  4:02 [RFC] blk-mq: clean up the hctx restart Jianchao Wang
2018-07-31  4:58 ` Ming Lei
2018-07-31  5:19   ` jianchao.wang
2018-07-31  6:16     ` Ming Lei
2018-08-01  2:17       ` jianchao.wang
2018-08-01  8:58         ` Ming Lei
2018-08-01 13:37           ` jianchao.wang
2018-08-02 10:39             ` Ming Lei
2018-08-02 15:52           ` Bart Van Assche
2018-08-02 16:58             ` Ming Lei
2018-08-02 17:08               ` Bart Van Assche
2018-08-02 17:17                 ` Ming Lei [this message]
2018-08-02 17:24                   ` Bart Van Assche
2018-08-03  0:35                     ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180802171723.GD8928@ming.t460p \
    --to=ming.lei@redhat.com \
    --cc=Bart.VanAssche@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=jianchao.w.wang@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox