* [PATCH] ASoC: wm8994: Fix missing break in switch
@ 2018-08-06 12:14 Gustavo A. R. Silva
2018-08-06 12:54 ` Charles Keepax
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-06 12:14 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: Valdis Kletnieks, patches, alsa-devel, linux-kernel,
Gustavo A. R. Silva
Add missing break statement in order to prevent the code from falling
through to the default case.
Cc: stable@vger.kernel.org
Addresses-Coverity-ID: 115050 ("Missing break in switch")
Reported-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
sound/soc/codecs/wm8994.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c
index 62f8c5b..14f1b0c 100644
--- a/sound/soc/codecs/wm8994.c
+++ b/sound/soc/codecs/wm8994.c
@@ -2432,7 +2432,7 @@ static int wm8994_set_dai_sysclk(struct snd_soc_dai *dai,
snd_soc_component_update_bits(component, WM8994_POWER_MANAGEMENT_2,
WM8994_OPCLK_ENA, 0);
}
- /* fall through */
+ break;
default:
return -EINVAL;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: wm8994: Fix missing break in switch
2018-08-06 12:14 [PATCH] ASoC: wm8994: Fix missing break in switch Gustavo A. R. Silva
@ 2018-08-06 12:54 ` Charles Keepax
0 siblings, 0 replies; 2+ messages in thread
From: Charles Keepax @ 2018-08-06 12:54 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Valdis Kletnieks, patches, alsa-devel, linux-kernel
On Mon, Aug 06, 2018 at 07:14:51AM -0500, Gustavo A. R. Silva wrote:
> Add missing break statement in order to prevent the code from falling
> through to the default case.
>
> Cc: stable@vger.kernel.org
> Addresses-Coverity-ID: 115050 ("Missing break in switch")
> Reported-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-06 12:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-06 12:14 [PATCH] ASoC: wm8994: Fix missing break in switch Gustavo A. R. Silva
2018-08-06 12:54 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox