From: Greg KH <gregkh@linuxfoundation.org>
To: Michael Anckaert <michael.anckaert@sinax.be>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: netlogic: Fixed comments to include SPDX-License-Identifier
Date: Sat, 11 Aug 2018 18:26:05 +0200 [thread overview]
Message-ID: <20180811162605.GA20944@kroah.com> (raw)
In-Reply-To: <20180811161505.GA7309@winston.localdomain>
On Sat, Aug 11, 2018 at 06:15:05PM +0200, Michael Anckaert wrote:
> This patch fixes some issues with missing SPDX-License-Identifier
> comments.
>
> Disclaimer: this is my first patch and instructions were taken from the
> KernelNewbies project.
This does not belong in a changelog comment. If you want to put info
like this, put it below the --- line.
>
> Signed-off-by: Michael Anckaert <michael.anckaert@sinax.be>
> ---
> drivers/staging/netlogic/Kconfig | 6 +++---
> drivers/staging/netlogic/platform_net.c | 1 +
> drivers/staging/netlogic/platform_net.h | 1 +
> drivers/staging/netlogic/xlr_net.c | 1 +
> drivers/staging/netlogic/xlr_net.h | 1 +
> 5 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/netlogic/Kconfig b/drivers/staging/netlogic/Kconfig
> index d660de51b541..ab0b756bc08b 100644
> --- a/drivers/staging/netlogic/Kconfig
> +++ b/drivers/staging/netlogic/Kconfig
> @@ -2,6 +2,6 @@ config NETLOGIC_XLR_NET
> tristate "Netlogic XLR/XLS network device"
> depends on CPU_XLR
> select PHYLIB
> - ---help---
> - This driver support Netlogic XLR/XLS on chip gigabit
> - Ethernet.
> + help
> + This driver support Netlogic XLR/XLS on chip gigabit
> + Ethernet.
This change has nothing to do with spdx identifiers :(
Please fix up and resend as 2 different patches.
thanks,
greg k-h
prev parent reply other threads:[~2018-08-11 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 16:15 [PATCH] staging: netlogic: Fixed comments to include SPDX-License-Identifier Michael Anckaert
2018-08-11 16:26 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180811162605.GA20944@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.anckaert@sinax.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox