* [PATCH] staging: netlogic: Fixed comments to include SPDX-License-Identifier
@ 2018-08-11 16:15 Michael Anckaert
2018-08-11 16:26 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Michael Anckaert @ 2018-08-11 16:15 UTC (permalink / raw)
To: gregkh, devel, linux-kernel
This patch fixes some issues with missing SPDX-License-Identifier
comments.
Disclaimer: this is my first patch and instructions were taken from the
KernelNewbies project.
Signed-off-by: Michael Anckaert <michael.anckaert@sinax.be>
---
drivers/staging/netlogic/Kconfig | 6 +++---
drivers/staging/netlogic/platform_net.c | 1 +
drivers/staging/netlogic/platform_net.h | 1 +
drivers/staging/netlogic/xlr_net.c | 1 +
drivers/staging/netlogic/xlr_net.h | 1 +
5 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/netlogic/Kconfig b/drivers/staging/netlogic/Kconfig
index d660de51b541..ab0b756bc08b 100644
--- a/drivers/staging/netlogic/Kconfig
+++ b/drivers/staging/netlogic/Kconfig
@@ -2,6 +2,6 @@ config NETLOGIC_XLR_NET
tristate "Netlogic XLR/XLS network device"
depends on CPU_XLR
select PHYLIB
- ---help---
- This driver support Netlogic XLR/XLS on chip gigabit
- Ethernet.
+ help
+ This driver support Netlogic XLR/XLS on chip gigabit
+ Ethernet.
diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
index abf4c71ee66b..3886c99c1f68 100644
--- a/drivers/staging/netlogic/platform_net.c
+++ b/drivers/staging/netlogic/platform_net.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
* Copyright (c) 2003-2012 Broadcom Corporation
* All Rights Reserved
diff --git a/drivers/staging/netlogic/platform_net.h b/drivers/staging/netlogic/platform_net.h
index e1b27f649590..1d994f0d0995 100644
--- a/drivers/staging/netlogic/platform_net.h
+++ b/drivers/staging/netlogic/platform_net.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Copyright (c) 2003-2012 Broadcom Corporation
* All Rights Reserved
diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
index e461168313bf..201db10692de 100644
--- a/drivers/staging/netlogic/xlr_net.c
+++ b/drivers/staging/netlogic/xlr_net.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
* Copyright (c) 2003-2012 Broadcom Corporation
* All Rights Reserved
diff --git a/drivers/staging/netlogic/xlr_net.h b/drivers/staging/netlogic/xlr_net.h
index f76e16cfd15d..de51d64c1f23 100644
--- a/drivers/staging/netlogic/xlr_net.h
+++ b/drivers/staging/netlogic/xlr_net.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Copyright (c) 2003-2012 Broadcom Corporation
* All Rights Reserved
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: netlogic: Fixed comments to include SPDX-License-Identifier
2018-08-11 16:15 [PATCH] staging: netlogic: Fixed comments to include SPDX-License-Identifier Michael Anckaert
@ 2018-08-11 16:26 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-08-11 16:26 UTC (permalink / raw)
To: Michael Anckaert; +Cc: devel, linux-kernel
On Sat, Aug 11, 2018 at 06:15:05PM +0200, Michael Anckaert wrote:
> This patch fixes some issues with missing SPDX-License-Identifier
> comments.
>
> Disclaimer: this is my first patch and instructions were taken from the
> KernelNewbies project.
This does not belong in a changelog comment. If you want to put info
like this, put it below the --- line.
>
> Signed-off-by: Michael Anckaert <michael.anckaert@sinax.be>
> ---
> drivers/staging/netlogic/Kconfig | 6 +++---
> drivers/staging/netlogic/platform_net.c | 1 +
> drivers/staging/netlogic/platform_net.h | 1 +
> drivers/staging/netlogic/xlr_net.c | 1 +
> drivers/staging/netlogic/xlr_net.h | 1 +
> 5 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/netlogic/Kconfig b/drivers/staging/netlogic/Kconfig
> index d660de51b541..ab0b756bc08b 100644
> --- a/drivers/staging/netlogic/Kconfig
> +++ b/drivers/staging/netlogic/Kconfig
> @@ -2,6 +2,6 @@ config NETLOGIC_XLR_NET
> tristate "Netlogic XLR/XLS network device"
> depends on CPU_XLR
> select PHYLIB
> - ---help---
> - This driver support Netlogic XLR/XLS on chip gigabit
> - Ethernet.
> + help
> + This driver support Netlogic XLR/XLS on chip gigabit
> + Ethernet.
This change has nothing to do with spdx identifiers :(
Please fix up and resend as 2 different patches.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-11 16:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-11 16:15 [PATCH] staging: netlogic: Fixed comments to include SPDX-License-Identifier Michael Anckaert
2018-08-11 16:26 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox