* [PATCH -next] drm: Remove set but not used variable 'config'
@ 2018-09-11 6:20 YueHaibing
2018-09-11 7:34 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-09-11 6:20 UTC (permalink / raw)
To: Gustavo Padovan, Maarten Lankhorst, Sean Paul, David Airlie
Cc: YueHaibing, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/drm_plane.c: In function 'drm_mode_getplane_res':
drivers/gpu/drm/drm_plane.c:475:26: warning:
variable 'config' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/drm_plane.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
index 36bf3fe..4a72c68 100644
--- a/drivers/gpu/drm/drm_plane.c
+++ b/drivers/gpu/drm/drm_plane.c
@@ -472,7 +472,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data,
struct drm_file *file_priv)
{
struct drm_mode_get_plane_res *plane_resp = data;
- struct drm_mode_config *config;
struct drm_plane *plane;
uint32_t __user *plane_ptr;
int count = 0;
@@ -480,7 +479,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data,
if (!drm_core_check_feature(dev, DRIVER_MODESET))
return -EINVAL;
- config = &dev->mode_config;
plane_ptr = u64_to_user_ptr(plane_resp->plane_id_ptr);
/*
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm: Remove set but not used variable 'config'
2018-09-11 6:20 [PATCH -next] drm: Remove set but not used variable 'config' YueHaibing
@ 2018-09-11 7:34 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2018-09-11 7:34 UTC (permalink / raw)
To: YueHaibing
Cc: Gustavo Padovan, Maarten Lankhorst, Sean Paul, David Airlie,
kernel-janitors, linux-kernel, dri-devel
On Tue, Sep 11, 2018 at 06:20:14AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/drm_plane.c: In function 'drm_mode_getplane_res':
> drivers/gpu/drm/drm_plane.c:475:26: warning:
> variable 'config' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks.
-Daniel
> ---
> drivers/gpu/drm/drm_plane.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
> index 36bf3fe..4a72c68 100644
> --- a/drivers/gpu/drm/drm_plane.c
> +++ b/drivers/gpu/drm/drm_plane.c
> @@ -472,7 +472,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data,
> struct drm_file *file_priv)
> {
> struct drm_mode_get_plane_res *plane_resp = data;
> - struct drm_mode_config *config;
> struct drm_plane *plane;
> uint32_t __user *plane_ptr;
> int count = 0;
> @@ -480,7 +479,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data,
> if (!drm_core_check_feature(dev, DRIVER_MODESET))
> return -EINVAL;
>
> - config = &dev->mode_config;
> plane_ptr = u64_to_user_ptr(plane_resp->plane_id_ptr);
>
> /*
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-11 7:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-11 6:20 [PATCH -next] drm: Remove set but not used variable 'config' YueHaibing
2018-09-11 7:34 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox