* [PATCH] ASoC: remove redundant include
@ 2018-09-18 8:16 zhong jiang
2018-09-18 8:38 ` Charles Keepax
0 siblings, 1 reply; 2+ messages in thread
From: zhong jiang @ 2018-09-18 8:16 UTC (permalink / raw)
To: broonie; +Cc: lgirdwood, oder_chiou, bardliao, perex, tiwai, linux-kernel
module.h already contained moduleparam.h, so it is safe to remove
the redundant include.
The issue is detected with the help of Coccinelle.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
sound/soc/codecs/rt5651.c | 1 -
sound/soc/codecs/wm8904.c | 1 -
sound/soc/codecs/wm8974.c | 1 -
sound/soc/soc-dapm.c | 1 -
4 files changed, 4 deletions(-)
diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c
index 5bcedbc..b7ba643 100644
--- a/sound/soc/codecs/rt5651.c
+++ b/sound/soc/codecs/rt5651.c
@@ -10,7 +10,6 @@
*/
#include <linux/module.h>
-#include <linux/moduleparam.h>
#include <linux/init.h>
#include <linux/delay.h>
#include <linux/pm.h>
diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c
index 1965635..2a3e5fb 100644
--- a/sound/soc/codecs/wm8904.c
+++ b/sound/soc/codecs/wm8904.c
@@ -13,7 +13,6 @@
#include <linux/clk.h>
#include <linux/module.h>
-#include <linux/moduleparam.h>
#include <linux/init.h>
#include <linux/delay.h>
#include <linux/pm.h>
diff --git a/sound/soc/codecs/wm8974.c b/sound/soc/codecs/wm8974.c
index 43edaf8..593a119 100644
--- a/sound/soc/codecs/wm8974.c
+++ b/sound/soc/codecs/wm8974.c
@@ -11,7 +11,6 @@
*/
#include <linux/module.h>
-#include <linux/moduleparam.h>
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/delay.h>
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 43983c6..ee6b975 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -18,7 +18,6 @@
// device reopen.
#include <linux/module.h>
-#include <linux/moduleparam.h>
#include <linux/init.h>
#include <linux/async.h>
#include <linux/delay.h>
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: remove redundant include
2018-09-18 8:16 [PATCH] ASoC: remove redundant include zhong jiang
@ 2018-09-18 8:38 ` Charles Keepax
0 siblings, 0 replies; 2+ messages in thread
From: Charles Keepax @ 2018-09-18 8:38 UTC (permalink / raw)
To: zhong jiang
Cc: broonie, lgirdwood, oder_chiou, bardliao, perex, tiwai,
linux-kernel
On Tue, Sep 18, 2018 at 04:16:24PM +0800, zhong jiang wrote:
> module.h already contained moduleparam.h, so it is safe to remove
> the redundant include.
>
> The issue is detected with the help of Coccinelle.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
For the Wolfson bits:
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-18 8:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-18 8:16 [PATCH] ASoC: remove redundant include zhong jiang
2018-09-18 8:38 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox