[PATCH] Fix clang warning -Wpointer-bool-conversion by removing unnecessary check in regd.c

[PATCH] Fix clang warning -Wpointer-bool-conversion by removing unnecessary check in regd.c

[Karthik Nishanth]

The member regd of the struct rtl_priv is true in a boolean context.

drivers/staging/rtlwifi/regd.c:413:27: warning: address of 'rtlpriv->regd' will always
      evaluate to 'true' [-Wpointer-bool-conversion]
        if (!wiphy || !&rtlpriv->regd)
                      ~ ~~~~~~~~~^~~~
1 warning generated.

Link: https://github.com/ClangBuiltLinux/linux/issues/170

Signed-off-by: Karthik Nishanth <nishanthkarthik@live.com>
---
 drivers/staging/rtlwifi/regd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtlwifi/regd.c b/drivers/staging/rtlwifi/regd.c
index 3afd206ce4b1..5213ca771175 100644
--- a/drivers/staging/rtlwifi/regd.c
+++ b/drivers/staging/rtlwifi/regd.c
@@ -410,7 +410,7 @@ int rtl_regd_init(struct ieee80211_hw *hw,
 	struct wiphy *wiphy = hw->wiphy;
 	struct country_code_to_enum_rd *country = NULL;
 
-	if (!wiphy || !&rtlpriv->regd)
+	if (!wiphy)
 		return -EINVAL;
 
 	/* init country_code from efuse channel plan */
-- 
2.19.0

Re: [PATCH] Fix clang warning -Wpointer-bool-conversion by removing unnecessary check in regd.c

[Dan Carpenter]

The subject needs a subsystem prefix.  It's also slightly long.

[PATCH] Staging: rtlwifi: remove unnecessary NULL check

regards,
dan carpenter

Re: [PATCH] Fix clang warning -Wpointer-bool-conversion by removing unnecessary check in regd.c

[Karthik Nishanth]

Do I submit a new patch with the modified subject?

On Sat, Sep 22, 2018 at 03:44:32PM +0300, Dan Carpenter wrote:
>The subject needs a subsystem prefix.  It's also slightly long.
>
>[PATCH] Staging: rtlwifi: remove unnecessary NULL check
>
>regards,
>dan carpenter
>


Karthik Nishanth

Re: [PATCH] Fix clang warning -Wpointer-bool-conversion by removing unnecessary check in regd.c

[Dan Carpenter]

On Sat, Sep 22, 2018 at 01:40:19PM +0000, Karthik Nishanth wrote:
> Do I submit a new patch with the modified subject?
> 

Yeah.  Put [PATCH v2] in the subject and then at the end of the patch
description put:

Signed-off-by: Your Name <email>
---
v2: changed the subject.

regards,
dan carpenter