From: Jiri Olsa <jolsa@redhat.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v12 3/3]: perf record: extend trace writing to multi AIO
Date: Thu, 11 Oct 2018 15:46:05 +0200 [thread overview]
Message-ID: <20181011134605.GD29634@krava> (raw)
In-Reply-To: <39da34d3-7198-7514-b000-7bfbf382e526@linux.intel.com>
On Tue, Oct 09, 2018 at 11:59:31AM +0300, Alexey Budankov wrote:
SNIP
> @@ -709,12 +729,13 @@ static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evli
> goto out;
> }
> } else {
> + int idx;
> /*
> * Call record__aio_sync() to wait till map->data buffer
> * becomes available after previous aio write request.
> */
> - record__aio_sync(map);
> - if (perf_mmap__aio_push(map, rec, record__aio_pushfn, &off) != 0) {
> + idx = record__aio_sync(map, false);
looks like record__aio_sync can return -1,
how is it not breaking the perf_mmap__aio_push call below?
> + if (perf_mmap__aio_push(map, rec, idx, record__aio_pushfn, &off) != 0) {
> record__aio_set_pos(trace_fd, off);
> rc = -1;
> goto out;
SNIP
next prev parent reply other threads:[~2018-10-11 13:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 8:39 [PATCH v12 0/3]: perf: reduce data loss when profiling highly parallel CPU bound workloads Alexey Budankov
2018-10-09 8:57 ` [PATCH v12 1/3] perf util: map data buffer for preserving collected data Alexey Budankov
2018-10-09 8:58 ` [PATCH v12 2/3]: perf record: enable asynchronous trace writing Alexey Budankov
2018-10-11 13:45 ` Jiri Olsa
2018-10-11 16:15 ` Alexey Budankov
2018-10-11 13:45 ` Jiri Olsa
2018-10-11 16:15 ` Alexey Budankov
2018-10-11 13:46 ` Jiri Olsa
2018-10-11 16:29 ` Alexey Budankov
2018-10-11 14:15 ` Jiri Olsa
2018-10-11 16:31 ` Alexey Budankov
2018-10-09 8:59 ` [PATCH v12 3/3]: perf record: extend trace writing to multi AIO Alexey Budankov
2018-10-11 13:45 ` Jiri Olsa
2018-10-11 16:14 ` Alexey Budankov
2018-10-11 13:46 ` Jiri Olsa [this message]
2018-10-11 16:24 ` Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011134605.GD29634@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox