From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v12 3/3]: perf record: extend trace writing to multi AIO
Date: Thu, 11 Oct 2018 19:14:03 +0300 [thread overview]
Message-ID: <7dedfcb0-f39a-7117-1b61-d0cac2fd1f1e@linux.intel.com> (raw)
In-Reply-To: <20181011134559.GC29634@krava>
Hi,
On 11.10.2018 16:45, Jiri Olsa wrote:
> On Tue, Oct 09, 2018 at 11:59:31AM +0300, Alexey Budankov wrote:
<SNIP>
>
>> @@ -1886,8 +1917,8 @@ static struct option __record_options[] = {
>> OPT_BOOLEAN(0, "dry-run", &dry_run,
>> "Parse options then exit"),
>> #ifdef HAVE_AIO_SUPPORT
>> - OPT_CALLBACK_NOOPT(0, "aio", &record.opts,
>> - NULL, "Enable asynchronous trace writing mode",
>
> hum, why removing --aio option? I though we will have:
>
> perf record --aio .... # enables aio with default settings
> perf record --aio-cblocks=3 ... # enabled aio with aio-cblocks=3
It is possible to avoid the complication using only one --aio option like this:
perf record --aio ... # enables aio with default (=1)
perf record --aio=4 ... # enables aio with parameter = 4
--aio-cblocks=4 still works when specified like --aio=4.
Thanks,
Alexey
next prev parent reply other threads:[~2018-10-11 16:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 8:39 [PATCH v12 0/3]: perf: reduce data loss when profiling highly parallel CPU bound workloads Alexey Budankov
2018-10-09 8:57 ` [PATCH v12 1/3] perf util: map data buffer for preserving collected data Alexey Budankov
2018-10-09 8:58 ` [PATCH v12 2/3]: perf record: enable asynchronous trace writing Alexey Budankov
2018-10-11 13:45 ` Jiri Olsa
2018-10-11 16:15 ` Alexey Budankov
2018-10-11 13:45 ` Jiri Olsa
2018-10-11 16:15 ` Alexey Budankov
2018-10-11 13:46 ` Jiri Olsa
2018-10-11 16:29 ` Alexey Budankov
2018-10-11 14:15 ` Jiri Olsa
2018-10-11 16:31 ` Alexey Budankov
2018-10-09 8:59 ` [PATCH v12 3/3]: perf record: extend trace writing to multi AIO Alexey Budankov
2018-10-11 13:45 ` Jiri Olsa
2018-10-11 16:14 ` Alexey Budankov [this message]
2018-10-11 13:46 ` Jiri Olsa
2018-10-11 16:24 ` Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dedfcb0-f39a-7117-1b61-d0cac2fd1f1e@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox