* [PATCH] ARM: mm: dump: Change to use DEFINE_SHOW_ATTRIBUTE macro
@ 2018-11-05 14:32 Yangtao Li
2018-11-05 17:01 ` Laura Abbott
0 siblings, 1 reply; 3+ messages in thread
From: Yangtao Li @ 2018-11-05 14:32 UTC (permalink / raw)
To: linux, jinb.park7, labbott, keescook
Cc: linux-arm-kernel, linux-kernel, Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
arch/arm/mm/ptdump_debugfs.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/arch/arm/mm/ptdump_debugfs.c b/arch/arm/mm/ptdump_debugfs.c
index be8d87be4b93..201cd467a739 100644
--- a/arch/arm/mm/ptdump_debugfs.c
+++ b/arch/arm/mm/ptdump_debugfs.c
@@ -12,17 +12,7 @@ static int ptdump_show(struct seq_file *m, void *v)
return 0;
}
-static int ptdump_open(struct inode *inode, struct file *file)
-{
- return single_open(file, ptdump_show, inode->i_private);
-}
-
-static const struct file_operations ptdump_fops = {
- .open = ptdump_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(ptdump);
int ptdump_debugfs_register(struct ptdump_info *info, const char *name)
{
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: mm: dump: Change to use DEFINE_SHOW_ATTRIBUTE macro
2018-11-05 14:32 [PATCH] ARM: mm: dump: Change to use DEFINE_SHOW_ATTRIBUTE macro Yangtao Li
@ 2018-11-05 17:01 ` Laura Abbott
2018-11-05 17:15 ` Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: Laura Abbott @ 2018-11-05 17:01 UTC (permalink / raw)
To: Yangtao Li, linux, jinb.park7, keescook; +Cc: linux-arm-kernel, linux-kernel
On 11/5/18 6:32 AM, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
Acked-by: Laura Abbott <labbott@redhat.com>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> arch/arm/mm/ptdump_debugfs.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/arch/arm/mm/ptdump_debugfs.c b/arch/arm/mm/ptdump_debugfs.c
> index be8d87be4b93..201cd467a739 100644
> --- a/arch/arm/mm/ptdump_debugfs.c
> +++ b/arch/arm/mm/ptdump_debugfs.c
> @@ -12,17 +12,7 @@ static int ptdump_show(struct seq_file *m, void *v)
> return 0;
> }
>
> -static int ptdump_open(struct inode *inode, struct file *file)
> -{
> - return single_open(file, ptdump_show, inode->i_private);
> -}
> -
> -static const struct file_operations ptdump_fops = {
> - .open = ptdump_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(ptdump);
>
> int ptdump_debugfs_register(struct ptdump_info *info, const char *name)
> {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: mm: dump: Change to use DEFINE_SHOW_ATTRIBUTE macro
2018-11-05 17:01 ` Laura Abbott
@ 2018-11-05 17:15 ` Kees Cook
0 siblings, 0 replies; 3+ messages in thread
From: Kees Cook @ 2018-11-05 17:15 UTC (permalink / raw)
To: Laura Abbott
Cc: Yangtao Li, Russell King, Jinbum Park, linux-arm-kernel, LKML
On Mon, Nov 5, 2018 at 9:01 AM, Laura Abbott <labbott@redhat.com> wrote:
> On 11/5/18 6:32 AM, Yangtao Li wrote:
>>
>> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>>
>
> Acked-by: Laura Abbott <labbott@redhat.com>
>
>
>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>> ---
>> arch/arm/mm/ptdump_debugfs.c | 12 +-----------
>> 1 file changed, 1 insertion(+), 11 deletions(-)
>>
>> diff --git a/arch/arm/mm/ptdump_debugfs.c b/arch/arm/mm/ptdump_debugfs.c
>> index be8d87be4b93..201cd467a739 100644
>> --- a/arch/arm/mm/ptdump_debugfs.c
>> +++ b/arch/arm/mm/ptdump_debugfs.c
>> @@ -12,17 +12,7 @@ static int ptdump_show(struct seq_file *m, void *v)
>> return 0;
>> }
>> -static int ptdump_open(struct inode *inode, struct file *file)
>> -{
>> - return single_open(file, ptdump_show, inode->i_private);
>> -}
>> -
>> -static const struct file_operations ptdump_fops = {
>> - .open = ptdump_open,
>> - .read = seq_read,
>> - .llseek = seq_lseek,
>> - .release = single_release,
>> -};
>> +DEFINE_SHOW_ATTRIBUTE(ptdump);
Nice! Can you do the same for arch/x86/mm/debug_pagetables.c too?
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
>> int ptdump_debugfs_register(struct ptdump_info *info, const char
>> *name)
>> {
>>
>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-05 17:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-05 14:32 [PATCH] ARM: mm: dump: Change to use DEFINE_SHOW_ATTRIBUTE macro Yangtao Li
2018-11-05 17:01 ` Laura Abbott
2018-11-05 17:15 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox