From: LABBE Corentin <clabbe@baylibre.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Biggers <ebiggers@kernel.org>,
nhorman@tuxdriver.com,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 01/11] crypto: move crypto_alg_get/crypto_alg_put to linux/crypto.h
Date: Tue, 20 Nov 2018 06:46:59 +0100 [thread overview]
Message-ID: <20181120054659.GA12679@Red> (raw)
In-Reply-To: <20181120031047.diqgmbluclbbkhav@gondor.apana.org.au>
On Tue, Nov 20, 2018 at 11:10:47AM +0800, Herbert Xu wrote:
> On Mon, Nov 19, 2018 at 12:25:10PM -0800, Ard Biesheuvel wrote:
> > On Mon, 19 Nov 2018 at 11:53, Corentin Labbe <clabbe@baylibre.com> wrote:
> > >
> > > Since we will need crypto_alg_get/crypto_alg_put for "locking"
> > > crypto_alg when updating stats, we need it to be via linux/crypto.h
> > >
> >
> > This seems backwards to me. Surely, crypto stats are permitted to use
> > the internal crypto API?
>
> I agree.
>
I dont understand what is backwards ? moving or using ?
What do you suggest for "locking" crypto_alg ?
Regards
next prev parent reply other threads:[~2018-11-20 5:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 19:53 [PATCH v2 00/11] crypto: crypto_user_stat: misc enhancement Corentin Labbe
2018-11-19 19:53 ` [PATCH v2 01/11] crypto: move crypto_alg_get/crypto_alg_put to linux/crypto.h Corentin Labbe
2018-11-19 20:25 ` Ard Biesheuvel
2018-11-20 3:10 ` Herbert Xu
2018-11-20 5:46 ` LABBE Corentin [this message]
2018-11-20 5:48 ` Herbert Xu
2018-11-19 19:53 ` [PATCH v2 02/11] crypto: crypto_user_stat: made crypto_user_stat optional Corentin Labbe
2018-11-19 19:53 ` [PATCH v2 03/11] crypto: CRYPTO_STATS should depend on CRYPTO_USER Corentin Labbe
2018-11-19 19:53 ` [PATCH v2 04/11] crypto: crypto_user_stat: convert all stats from u32 to u64 Corentin Labbe
2018-11-19 19:53 ` [PATCH v2 05/11] crypto: crypto_user_stat: split user space crypto stat structures Corentin Labbe
2018-11-19 19:53 ` [PATCH v2 06/11] crypto: tool: getstat: convert user space example to the new crypto_user_stat uapi Corentin Labbe
2018-11-19 19:53 ` [PATCH v2 07/11] crypto: crypto_user_stat: fix use_after_free of struct xxx_request Corentin Labbe
2018-11-19 19:53 ` [PATCH v2 08/11] crypto: crypto_user_stat: Fix invalid stat reporting Corentin Labbe
2018-11-19 19:53 ` [PATCH v2 09/11] crypto: crypto_user_stat: remove intermediate variable Corentin Labbe
2018-11-19 19:53 ` [PATCH v2 10/11] crypto: crypto_user_stat: Split stats in multiple structures Corentin Labbe
2018-11-19 19:53 ` [PATCH v2 11/11] crypto: crypto_user_stat: rename err_cnt parameter Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120054659.GA12679@Red \
--to=clabbe@baylibre.com \
--cc=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox