From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Huijin Park <huijin.park@samsung.com>,
Boris Brezillon <boris.brezillon@bootlin.com>
Cc: linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-mtd@lists.infradead.org, bbanghj.park@gmail.com
Subject: Re: [v3] mtd: spi-nor: cast to u64 to avoid uint overflows
Date: Mon, 3 Dec 2018 11:34:59 +0100 [thread overview]
Message-ID: <20181203113459.05f29284@bbrezillon> (raw)
In-Reply-To: <20181203075154.28637-1-boris.brezillon@bootlin.com>
On Mon, 3 Dec 2018 08:51:54 +0100
Boris Brezillon <boris.brezillon@bootlin.com> wrote:
> On Wed, 2018-11-28 at 08:02:14 UTC, Huijin Park wrote:
> > From: "huijin.park" <huijin.park@samsung.com>
> >
> > The "params->size" is defined as "u64".
> > And "info->sector_size" and "info->n_sectors" are defined as
> > unsigned int and u16.
> > Thus, u64 data might have strange data(loss data) if the result
> > overflows an unsigned int.
> > This patch casts "info->sector_size" to an u64.
> >
> > Signed-off-by: huijin.park <huijin.park@samsung.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Applied to http://git.infradead.org/linux-mtd.git mtd/next, thanks.
Oops, should I been queued to spi-nor/next. I dropped the patch and
will soon push it to spi-nor/next.
next prev parent reply other threads:[~2018-12-03 10:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181128080244eucas1p15d9478c4fdbb0609005a12d24703d6d8@eucas1p1.samsung.com>
2018-11-28 8:02 ` [PATCH v3] mtd: spi-nor: cast to u64 to avoid uint overflows Huijin Park
2018-11-28 8:41 ` Geert Uytterhoeven
2018-12-03 7:51 ` [v3] " Boris Brezillon
2018-12-03 10:34 ` Boris Brezillon [this message]
2018-12-03 8:12 ` [PATCH v3] " Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203113459.05f29284@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=bbanghj.park@gmail.com \
--cc=geert@linux-m68k.org \
--cc=huijin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox