[PATCH v2] driver core: platform: Respect return code of platform_device_register_full()

[PATCH v2] driver core: platform: Respect return code of platform_device_register_full()

[Andy Shevchenko]

The platform_device_register_full() might return an error pointer. If we
instantiate platform device which is optional we may simplify the routine at
removal stage by simply calling platform_device_unregister(). For now it
requires to check parameter for being an error pointer in each caller.

To make users' life easier, check for an error pointer inside driver core.

Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
- rebase on top of linux-next since the conflicting patch has been applied there

 drivers/base/platform.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 0fb5f140f1b0..2c36bf490944 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -234,7 +234,7 @@ struct platform_object {
  */
 void platform_device_put(struct platform_device *pdev)
 {
-	if (pdev)
+	if (!IS_ERR_OR_NULL(pdev))
 		put_device(&pdev->dev);
 }
 EXPORT_SYMBOL_GPL(platform_device_put);
@@ -447,7 +447,7 @@ void platform_device_del(struct platform_device *pdev)
 {
 	int i;
 
-	if (pdev) {
+	if (!IS_ERR_OR_NULL(pdev)) {
 		device_del(&pdev->dev);
 
 		if (pdev->id_auto) {
-- 
2.19.2

Re: [PATCH v2] driver core: platform: Respect return code of platform_device_register_full()

[Greg Kroah-Hartman]

On Mon, Dec 03, 2018 at 08:21:41PM +0200, Andy Shevchenko wrote:
> The platform_device_register_full() might return an error pointer. If we
> instantiate platform device which is optional we may simplify the routine at
> removal stage by simply calling platform_device_unregister(). For now it
> requires to check parameter for being an error pointer in each caller.
> 
> To make users' life easier, check for an error pointer inside driver core.
> 
> Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> - rebase on top of linux-next since the conflicting patch has been applied there

What conflicting patch?  This now doesn't apply to my tree.

Let me fix it up by hand...

Re: [PATCH v2] driver core: platform: Respect return code of platform_device_register_full()

[Andy Shevchenko]

On Thu, Dec 6, 2018 at 2:59 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Mon, Dec 03, 2018 at 08:21:41PM +0200, Andy Shevchenko wrote:
> > The platform_device_register_full() might return an error pointer. If we
> > instantiate platform device which is optional we may simplify the routine at
> > removal stage by simply calling platform_device_unregister(). For now it
> > requires to check parameter for being an error pointer in each caller.
> >
> > To make users' life easier, check for an error pointer inside driver core.
> >
> > Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > - rebase on top of linux-next since the conflicting patch has been applied there
>
> What conflicting patch?  This now doesn't apply to my tree.

One patch from Heikki had been applied earlier, I rebased and sent v2
at the same day as this one.

>
> Let me fix it up by hand...
>


-- 
With Best Regards,
Andy Shevchenko