* Re: linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false
[not found] <DB7PR08MB3801DE2E52BE7BF2E0D7D0129C890@DB7PR08MB3801.eurprd08.prod.outlook.com>
@ 2019-01-07 12:27 ` gregkh
2019-01-07 13:08 ` Dan Carpenter
1 sibling, 0 replies; 2+ messages in thread
From: gregkh @ 2019-01-07 12:27 UTC (permalink / raw)
To: David Binderman; +Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
On Mon, Jan 07, 2019 at 11:40:08AM +0000, David Binderman wrote:
>
> Hello there,
>
> linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false because 'else if' condition matches previous condition at line 410.
>
> Source code is
>
> else if (pRaInfo->HighestRate > 0x0b)
> pRaInfo->PTModeSS = 2;
> else if (pRaInfo->HighestRate > 0x0b)
> pRaInfo->PTModeSS = 1;
>
> Suggest code rework.
Patches are always gladly accepted!
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false
[not found] <DB7PR08MB3801DE2E52BE7BF2E0D7D0129C890@DB7PR08MB3801.eurprd08.prod.outlook.com>
2019-01-07 12:27 ` linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false gregkh
@ 2019-01-07 13:08 ` Dan Carpenter
1 sibling, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2019-01-07 13:08 UTC (permalink / raw)
To: David Binderman
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
On Mon, Jan 07, 2019 at 11:40:08AM +0000, David Binderman wrote:
>
> Hello there,
>
> linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false because 'else if' condition matches previous condition at line 410.
>
> Source code is
>
> else if (pRaInfo->HighestRate > 0x0b)
> pRaInfo->PTModeSS = 2;
> else if (pRaInfo->HighestRate > 0x0b)
> pRaInfo->PTModeSS = 1;
>
That's true, but that's how to the code was originally when it was
committed 5 years ago so it's hard to tell what the fix should be...
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-07 13:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <DB7PR08MB3801DE2E52BE7BF2E0D7D0129C890@DB7PR08MB3801.eurprd08.prod.outlook.com>
2019-01-07 12:27 ` linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false gregkh
2019-01-07 13:08 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox