From: Lee Jones <lee.jones@linaro.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: tps68470: drop unused MODULE_DEVICE_TABLE
Date: Thu, 7 Feb 2019 09:49:58 +0000 [thread overview]
Message-ID: <20190207094958.GA20638@dell> (raw)
In-Reply-To: <1549480267-17822-1-git-send-email-paul.gortmaker@windriver.com>
On Wed, 06 Feb 2019, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> drivers/mfd/Kconfig:config MFD_TPS68470
> drivers/mfd/Kconfig: bool "TI TPS68470 Power Management / LED chips"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Hence we remove the MODULE_DEVICE_TABLE since it is a no-op for
> non-modular code.
>
> There is no removal of <linux/module.h> here because there isn't one.
> Instead, it is relying on including that implicitly from an ACPI header.
>
> In cleaning up the ACPI instance of module.h (which also isn't strictly
> needed), then this mfd driver breaks when MODULE_DEVICE_TABLE becomes
> undefined here.
>
> The easiest dependency solution is to simply defer the ACPI cleanup
> until this change is present in mainline.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2019-02-07 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 19:11 [PATCH] mfd: tps68470: drop unused MODULE_DEVICE_TABLE Paul Gortmaker
2019-02-07 9:49 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207094958.GA20638@dell \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox