* [PATCH][V3] regulator: axp20x: remove a redundant null check on rdev
@ 2019-02-15 9:45 Colin King
2019-02-18 8:12 ` Dan Carpenter
2019-02-18 8:40 ` Chen-Yu Tsai
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2019-02-15 9:45 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Chen-Yu Tsai; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently rdev is dereferenced when assigning desc before rdev is null
checked, this is leading to static analysis warnings. However, rdev
can never be null, so the null check is redundant and can be removed.
Detected by CoverityScan, CID#1476031 ("Dereference before null check")
Fixes: 77e3e3b165db ("regulator: axp20x: add software based soft_start for AXP209 LDO3")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
--
V2: Fix 2nd occurrance of this thinko
V3: Remove null check, Dan Carpenter noted that rdev can never be null.
---
drivers/regulator/axp20x-regulator.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index 6d081c8321a1..db1750df579d 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -372,9 +372,6 @@ static int axp20x_set_ramp_delay(struct regulator_dev *rdev, int ramp)
const int *slew_rates;
int rate_count = 0;
- if (!rdev)
- return -EINVAL;
-
desc = rdev->desc;
switch (axp20x->variant) {
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][V3] regulator: axp20x: remove a redundant null check on rdev
2019-02-15 9:45 [PATCH][V3] regulator: axp20x: remove a redundant null check on rdev Colin King
@ 2019-02-18 8:12 ` Dan Carpenter
2019-02-18 8:40 ` Chen-Yu Tsai
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2019-02-18 8:12 UTC (permalink / raw)
To: Colin King
Cc: Liam Girdwood, Mark Brown, Chen-Yu Tsai, kernel-janitors,
linux-kernel
On Fri, Feb 15, 2019 at 09:45:54AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently rdev is dereferenced when assigning desc before rdev is null
> checked, this is leading to static analysis warnings. However, rdev
> can never be null, so the null check is redundant and can be removed.
>
> Detected by CoverityScan, CID#1476031 ("Dereference before null check")
>
> Fixes: 77e3e3b165db ("regulator: axp20x: add software based soft_start for AXP209 LDO3")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> --
We need a third '-' character on the cut off marker.
>
> V2: Fix 2nd occurrance of this thinko
> V3: Remove null check, Dan Carpenter noted that rdev can never be null.
> ---
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][V3] regulator: axp20x: remove a redundant null check on rdev
2019-02-15 9:45 [PATCH][V3] regulator: axp20x: remove a redundant null check on rdev Colin King
2019-02-18 8:12 ` Dan Carpenter
@ 2019-02-18 8:40 ` Chen-Yu Tsai
1 sibling, 0 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2019-02-18 8:40 UTC (permalink / raw)
To: Colin King; +Cc: Liam Girdwood, Mark Brown, kernel-janitors, linux-kernel
On Fri, Feb 15, 2019 at 5:46 PM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently rdev is dereferenced when assigning desc before rdev is null
> checked, this is leading to static analysis warnings. However, rdev
> can never be null, so the null check is redundant and can be removed.
>
> Detected by CoverityScan, CID#1476031 ("Dereference before null check")
>
> Fixes: 77e3e3b165db ("regulator: axp20x: add software based soft_start for AXP209 LDO3")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-18 8:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-15 9:45 [PATCH][V3] regulator: axp20x: remove a redundant null check on rdev Colin King
2019-02-18 8:12 ` Dan Carpenter
2019-02-18 8:40 ` Chen-Yu Tsai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox