From: Mark Brown <broonie@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Codrin.Ciubotariu@microchip.com, lgirdwood@gmail.com,
dannenberg@ti.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ASoC: codecs: pcm186x: Fix energysense SLEEP bit
Date: Tue, 19 Feb 2019 17:18:03 +0000 [thread overview]
Message-ID: <20190219171803.GC20883@sirena.org.uk> (raw)
In-Reply-To: <eba29760-9ef7-9490-9f46-b3dbdf43ee05@ti.com>
[-- Attachment #1: Type: text/plain, Size: 412 bytes --]
On Tue, Feb 19, 2019 at 11:06:48AM -0600, Andrew F. Davis wrote:
> Did this work for you before? Strange it would if reversed, I wonder if
> the SLEEP bit is really doing anything here. Can investigate later, for
> this patch:
Thinking about it some more I'm wondering if it gets overridden by
something else (ie, the CODEC actually being asleep requires this being
set and some other thing being turned off).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-20 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 16:29 [PATCH v2 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB_SCALE() Codrin.Ciubotariu
2019-02-19 16:29 ` [PATCH v2 2/2] ASoC: codecs: pcm186x: Fix energysense SLEEP bit Codrin.Ciubotariu
2019-02-19 16:56 ` Mark Brown
2019-02-19 17:06 ` Andrew F. Davis
2019-02-19 17:18 ` Mark Brown [this message]
2019-02-20 10:56 ` Codrin.Ciubotariu
2019-02-19 17:05 ` [PATCH v2 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB_SCALE() Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219171803.GC20883@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Codrin.Ciubotariu@microchip.com \
--cc=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=dannenberg@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox