* [PATCH] RISC-V: Use IS_ENABLED(CONFIG_CMODEL_MEDLOW)
@ 2019-03-07 23:56 Joe Perches
2019-03-08 14:53 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2019-03-07 23:56 UTC (permalink / raw)
To: Palmer Dabbelt, Albert Ou; +Cc: linux-riscv, LKML
IS_ENABLED should generally use CONFIG_ prefaced symbols and
it doesn't appear as if there is a CMODEL_MEDLOW define.
Signed-off-by: Joe Perches <joe@perches.com>
---
arch/riscv/kernel/module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c
index 7dd308129b40..2872edce894d 100644
--- a/arch/riscv/kernel/module.c
+++ b/arch/riscv/kernel/module.c
@@ -141,7 +141,7 @@ static int apply_r_riscv_hi20_rela(struct module *me, u32 *location,
{
s32 hi20;
- if (IS_ENABLED(CMODEL_MEDLOW)) {
+ if (IS_ENABLED(CONFIG_CMODEL_MEDLOW)) {
pr_err(
"%s: target %016llx can not be addressed by the 32-bit offset from PC = %p\n",
me->name, (long long)v, location);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] RISC-V: Use IS_ENABLED(CONFIG_CMODEL_MEDLOW)
2019-03-07 23:56 [PATCH] RISC-V: Use IS_ENABLED(CONFIG_CMODEL_MEDLOW) Joe Perches
@ 2019-03-08 14:53 ` Christoph Hellwig
2019-03-29 7:41 ` Palmer Dabbelt
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2019-03-08 14:53 UTC (permalink / raw)
To: Joe Perches; +Cc: Palmer Dabbelt, Albert Ou, linux-riscv, LKML
On Thu, Mar 07, 2019 at 03:56:34PM -0800, Joe Perches wrote:
> IS_ENABLED should generally use CONFIG_ prefaced symbols and
> it doesn't appear as if there is a CMODEL_MEDLOW define.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V: Use IS_ENABLED(CONFIG_CMODEL_MEDLOW)
2019-03-08 14:53 ` Christoph Hellwig
@ 2019-03-29 7:41 ` Palmer Dabbelt
0 siblings, 0 replies; 3+ messages in thread
From: Palmer Dabbelt @ 2019-03-29 7:41 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: joe, aou, linux-riscv, linux-kernel
On Fri, 08 Mar 2019 06:53:02 PST (-0800), Christoph Hellwig wrote:
> On Thu, Mar 07, 2019 at 03:56:34PM -0800, Joe Perches wrote:
>> IS_ENABLED should generally use CONFIG_ prefaced symbols and
>> it doesn't appear as if there is a CMODEL_MEDLOW define.
>>
>> Signed-off-by: Joe Perches <joe@perches.com>
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks. This one is also in the list for the next RC.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-29 7:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-07 23:56 [PATCH] RISC-V: Use IS_ENABLED(CONFIG_CMODEL_MEDLOW) Joe Perches
2019-03-08 14:53 ` Christoph Hellwig
2019-03-29 7:41 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox