[PATCH] staging: ralink-gdma: Convert unsigned to unsigned int

[PATCH] staging: ralink-gdma: Convert unsigned to unsigned int

[Bharath Vedartham]

Fix the checkpatch.pl warning: "Use unsigned int instead of unsigned".

Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
---
 drivers/staging/ralink-gdma/ralink-gdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index 0b831f8..523c39e 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -162,7 +162,7 @@ static inline u32 gdma_dma_read(struct gdma_dma_dev *dma_dev, unsigned int reg)
 	return readl(dma_dev->base + reg);
 }
 
-static inline void gdma_dma_write(struct gdma_dma_dev *dma_dev, unsigned reg, u32 val)
+static inline void gdma_dma_write(struct gdma_dma_dev *dma_dev, unsigned int reg, u32 val)
 {
 	writel(val, dma_dev->base + reg);
 }
-- 
2.7.4

Re: [PATCH] staging: ralink-gdma: Convert unsigned to unsigned int

[Greg KH]

On Sat, Mar 23, 2019 at 05:04:44PM +0530, Bharath Vedartham wrote:
> Fix the checkpatch.pl warning: "Use unsigned int instead of unsigned".
> 
> Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
> ---
>  drivers/staging/ralink-gdma/ralink-gdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This patch also does not apply at all :(

Re: [PATCH] staging: ralink-gdma: Convert unsigned to unsigned int

[Bharath Vedartham]

On Sun, Mar 24, 2019 at 09:58:42AM +0100, Greg KH wrote:
> On Sat, Mar 23, 2019 at 05:04:44PM +0530, Bharath Vedartham wrote:
> > Fix the checkpatch.pl warning: "Use unsigned int instead of unsigned".
> > 
> > Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
> > ---
> >  drivers/staging/ralink-gdma/ralink-gdma.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This patch also does not apply at all :(

I have been working on linus's branch and not the staging branch. I
thought that linus's branch would have the latest updates and would be
the latest branch :( . Is it a problem if I use linus's branch for
staging drivers?

Re: [PATCH] staging: ralink-gdma: Convert unsigned to unsigned int

[Greg KH]

On Sun, Mar 24, 2019 at 03:07:48PM +0530, Bharath Vedartham wrote:
> On Sun, Mar 24, 2019 at 09:58:42AM +0100, Greg KH wrote:
> > On Sat, Mar 23, 2019 at 05:04:44PM +0530, Bharath Vedartham wrote:
> > > Fix the checkpatch.pl warning: "Use unsigned int instead of unsigned".
> > > 
> > > Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
> > > ---
> > >  drivers/staging/ralink-gdma/ralink-gdma.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > This patch also does not apply at all :(
> 
> I have been working on linus's branch and not the staging branch. I
> thought that linus's branch would have the latest updates and would be
> the latest branch :( . Is it a problem if I use linus's branch for
> staging drivers?

Yes, if you want to do kernel development, you always need to work off
of the subsystem tree that you are wanting to contribute to, or off of
linux-next.  Development trees can often be 3 months ahead of Linus's
tree depending on the time of the merge window.

The tree should always be listed in the MAINTAINERS file for what one to
use.

hope this helps,

greg k-h

Re: [PATCH] staging: ralink-gdma: Convert unsigned to unsigned int

[Bharath Vedartham]

On Sun, Mar 24, 2019 at 09:58:42AM +0100, Greg KH wrote:
> On Sat, Mar 23, 2019 at 05:04:44PM +0530, Bharath Vedartham wrote:
> > Fix the checkpatch.pl warning: "Use unsigned int instead of unsigned".
> > 
> > Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
> > ---
> >  drivers/staging/ralink-gdma/ralink-gdma.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This patch also does not apply at all :(
I have sent version 2 based of the latest staging branch.