From: Johan Hovold <johan@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Johan Hovold <johan@kernel.org>,
devel@driverdev.osuosl.org, elder@kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
Madhumitha Prabakaran <madhumithabiw@gmail.com>,
greybus-dev@lists.linaro.org
Subject: Re: [PATCH] Staging: greybus: Cleanup in header file control.h
Date: Mon, 15 Apr 2019 17:03:33 +0200 [thread overview]
Message-ID: <20190415150333.GE775@localhost> (raw)
In-Reply-To: <20190415144015.GB22423@kadam>
On Mon, Apr 15, 2019 at 05:40:16PM +0300, Dan Carpenter wrote:
> What I'm saying is that if we just apply it then we avoid the long
> discussion forever. The macro is OK, sure, but it's not like anyone is
> going to come back later and argue that macros are better or preferred.
That may be a valid argument, at least with respect to staging
currently (even if checkpatch isn't entirely too blame for this
particular "cleanup").
But then all eight or so instances should be replaced in one go, to
maintain consistency.
Johan
next prev parent reply other threads:[~2019-04-15 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 20:14 [PATCH] Staging: greybus: Cleanup in header file control.h Madhumitha Prabakaran
2019-04-15 13:10 ` Johan Hovold
2019-04-15 13:33 ` Dan Carpenter
2019-04-15 14:12 ` Johan Hovold
2019-04-15 14:40 ` Dan Carpenter
2019-04-15 15:03 ` Johan Hovold [this message]
2019-04-15 16:04 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415150333.GE775@localhost \
--to=johan@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhumithabiw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox