* [PATCH] drivers: staging :rtl8723bs :os_dep Remove Unneeded variable ret
@ 2019-05-12 11:32 Hariprasad Kelam
2019-05-13 9:34 ` Greg Kroah-Hartman
2019-05-13 10:41 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Hariprasad Kelam @ 2019-05-12 11:32 UTC (permalink / raw)
To: Greg Kroah-Hartman, Michael Straube, Mamta Shukla,
Emanuel Bennici, Wen Yang, Jia-Ju Bai, Hariprasad Kelam, devel,
linux-kernel, viswanath.barenkala
fix below issue reported by coccicheck
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2685:5-8: Unneeded
variable: "ret". Return "0" on line 3266
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index e3d3569..3f1ab6e 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -2682,7 +2682,6 @@ static int rtw_dbg_port(struct net_device *dev,
struct iw_request_info *info,
union iwreq_data *wrqu, char *extra)
{
- int ret = 0;
u8 major_cmd, minor_cmd;
u16 arg;
u32 extra_arg, *pdata, val32;
@@ -3263,7 +3262,7 @@ static int rtw_dbg_port(struct net_device *dev,
}
- return ret;
+ return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drivers: staging :rtl8723bs :os_dep Remove Unneeded variable ret
2019-05-12 11:32 [PATCH] drivers: staging :rtl8723bs :os_dep Remove Unneeded variable ret Hariprasad Kelam
@ 2019-05-13 9:34 ` Greg Kroah-Hartman
2019-05-13 10:41 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2019-05-13 9:34 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: Michael Straube, Mamta Shukla, Emanuel Bennici, Wen Yang,
Jia-Ju Bai, devel, linux-kernel, viswanath.barenkala
On Sun, May 12, 2019 at 05:02:45PM +0530, Hariprasad Kelam wrote:
> fix below issue reported by coccicheck
>
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2685:5-8: Unneeded
> variable: "ret". Return "0" on line 3266
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
For your subject line, put the ' ' character after the ':' character
always please.
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: staging :rtl8723bs :os_dep Remove Unneeded variable ret
2019-05-12 11:32 [PATCH] drivers: staging :rtl8723bs :os_dep Remove Unneeded variable ret Hariprasad Kelam
2019-05-13 9:34 ` Greg Kroah-Hartman
@ 2019-05-13 10:41 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2019-05-13 10:41 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: Greg Kroah-Hartman, Michael Straube, Mamta Shukla,
Emanuel Bennici, Wen Yang, Jia-Ju Bai, devel, linux-kernel,
viswanath.barenkala
Please "drivers" out of the subject line. We know it's drivers, so that
doesn't add any information. The "staging: " bit tells you which git
tree this path is in, and the "rtl8723bs: " tells you which driver it
is.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-13 10:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-12 11:32 [PATCH] drivers: staging :rtl8723bs :os_dep Remove Unneeded variable ret Hariprasad Kelam
2019-05-13 9:34 ` Greg Kroah-Hartman
2019-05-13 10:41 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox