From: "Simon Sandström" <simon@nikanor.nu>
To: gregkh@linuxfoundation.org
Cc: jeremy@azazel.net, dan.carpenter@oracle.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Simon Sandström" <simon@nikanor.nu>
Subject: [PATCH 3/6] staging: kpc2000: fix invalid linebreaks in cell_probe.c
Date: Wed, 22 May 2019 22:58:46 +0200 [thread overview]
Message-ID: <20190522205849.17444-4-simon@nikanor.nu> (raw)
In-Reply-To: <20190522205849.17444-1-simon@nikanor.nu>
Fixes checkpatch.pl error "else should follow close brace '}'" and
"trailing statements should be on next line".
Signed-off-by: Simon Sandström <simon@nikanor.nu>
---
drivers/staging/kpc2000/kpc2000/cell_probe.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_probe.c
index 51d32970f025..4742f909db79 100644
--- a/drivers/staging/kpc2000/kpc2000/cell_probe.c
+++ b/drivers/staging/kpc2000/kpc2000/cell_probe.c
@@ -85,8 +85,12 @@ static
void parse_core_table_entry(struct core_table_entry *cte, const u64 read_val, const u8 entry_rev)
{
switch (entry_rev) {
- case 0: parse_core_table_entry_v0(cte, read_val); break;
- default: cte->type = 0; break;
+ case 0:
+ parse_core_table_entry_v0(cte, read_val);
+ break;
+ default:
+ cte->type = 0;
+ break;
}
}
@@ -387,7 +391,8 @@ static int kp2000_setup_dma_controller(struct kp2000_device *pcard)
capabilities_reg = readq( pcard->dma_bar_base + KPC_DMA_S2C_BASE_OFFSET + (KPC_DMA_ENGINE_SIZE * i) );
if (capabilities_reg & ENGINE_CAP_PRESENT_MASK) {
err = create_dma_engine_core(pcard, (KPC_DMA_S2C_BASE_OFFSET + (KPC_DMA_ENGINE_SIZE * i)), i, pcard->pdev->irq);
- if (err) goto err_out;
+ if (err)
+ goto err_out;
}
}
// C2S Engines
@@ -395,7 +400,8 @@ static int kp2000_setup_dma_controller(struct kp2000_device *pcard)
capabilities_reg = readq( pcard->dma_bar_base + KPC_DMA_C2S_BASE_OFFSET + (KPC_DMA_ENGINE_SIZE * i) );
if (capabilities_reg & ENGINE_CAP_PRESENT_MASK) {
err = create_dma_engine_core(pcard, (KPC_DMA_C2S_BASE_OFFSET + (KPC_DMA_ENGINE_SIZE * i)), 32+i, pcard->pdev->irq);
- if (err) goto err_out;
+ if (err)
+ goto err_out;
}
}
@@ -418,7 +424,8 @@ int kp2000_probe_cores(struct kp2000_device *pcard)
dev_dbg(&pcard->pdev->dev, "kp2000_probe_cores(pcard = %p / %d)\n", pcard, pcard->card_num);
err = kp2000_setup_dma_controller(pcard);
- if (err) return err;
+ if (err)
+ return err;
INIT_LIST_HEAD(&pcard->uio_devices_list);
--
2.20.1
next prev parent reply other threads:[~2019-05-22 20:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 20:58 [PATCH 0/6] Fix coding style issues in drivers/staging/kpc2000 Simon Sandström
2019-05-22 20:58 ` [PATCH 1/6] staging: kpc2000: fix indent in cell_probe.c Simon Sandström
2019-05-23 7:26 ` Greg KH
2019-05-23 7:27 ` Greg KH
2019-05-23 8:03 ` Simon Sandström
2019-05-22 20:58 ` [PATCH 2/6] staging: kpc2000: add space between ) and { " Simon Sandström
2019-05-22 20:58 ` Simon Sandström [this message]
2019-05-22 20:58 ` [PATCH 4/6] staging: kpc2000: add spaces around operators " Simon Sandström
2019-05-22 20:58 ` [PATCH 5/6] staging: kpc2000: add space after comma " Simon Sandström
2019-05-22 20:58 ` [PATCH 6/6] staging: kpc2000: remove invalid spaces " Simon Sandström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522205849.17444-4-simon@nikanor.nu \
--to=simon@nikanor.nu \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy@azazel.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox