From: Greg KH <gregkh@linuxfoundation.org>
To: "Simon Sandström" <simon@nikanor.nu>
Cc: jeremy@azazel.net, dan.carpenter@oracle.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] staging: kpc2000: fix indent in cell_probe.c
Date: Thu, 23 May 2019 09:27:59 +0200 [thread overview]
Message-ID: <20190523072759.GA16656@kroah.com> (raw)
In-Reply-To: <20190523072625.GA16429@kroah.com>
On Thu, May 23, 2019 at 09:26:25AM +0200, Greg KH wrote:
> On Wed, May 22, 2019 at 10:58:44PM +0200, Simon Sandström wrote:
> > Use tabs instead of spaces for indentation.
> >
> > Signed-off-by: Simon Sandström <simon@nikanor.nu>
> > ---
> > drivers/staging/kpc2000/kpc2000/cell_probe.c | 574 +++++++++----------
> > 1 file changed, 287 insertions(+), 287 deletions(-)
> >
> > diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c b/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > index 0181b0a8ff82..6e034d115b47 100644
> > --- a/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > +++ b/drivers/staging/kpc2000/kpc2000/cell_probe.c
> > @@ -25,7 +25,7 @@
> > * D C2S DMA Present
> > * DDD C2S DMA Channel Number [up to 8 channels]
> > * II IRQ Count [0 to 3 IRQs per core]
> > - 1111111000
> > + * 1111111000
> > * IIIIIII IRQ Base Number [up to 128 IRQs per card]
> > * ___ Spare
> > *
>
> This chunk does not match what you said this commit did :(
>
> Please fix up and resend.
Actually, wait, rebase and resend after I apply your other patches.
I'll hand-edit this patch to remove this chunk as your other fixes are
good...
thanks,
greg k-h
next prev parent reply other threads:[~2019-05-23 7:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 20:58 [PATCH 0/6] Fix coding style issues in drivers/staging/kpc2000 Simon Sandström
2019-05-22 20:58 ` [PATCH 1/6] staging: kpc2000: fix indent in cell_probe.c Simon Sandström
2019-05-23 7:26 ` Greg KH
2019-05-23 7:27 ` Greg KH [this message]
2019-05-23 8:03 ` Simon Sandström
2019-05-22 20:58 ` [PATCH 2/6] staging: kpc2000: add space between ) and { " Simon Sandström
2019-05-22 20:58 ` [PATCH 3/6] staging: kpc2000: fix invalid linebreaks " Simon Sandström
2019-05-22 20:58 ` [PATCH 4/6] staging: kpc2000: add spaces around operators " Simon Sandström
2019-05-22 20:58 ` [PATCH 5/6] staging: kpc2000: add space after comma " Simon Sandström
2019-05-22 20:58 ` [PATCH 6/6] staging: kpc2000: remove invalid spaces " Simon Sandström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523072759.GA16656@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=jeremy@azazel.net \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@nikanor.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox