[git pull] habanalabs fixes for 5.2-rc1/2

[git pull] habanalabs fixes for 5.2-rc1/2

[Oded Gabbay]

Hi Greg,

This is the pull request containing fixes for 5.2-rc1/2.

It contains 2 fixes (1 of them for stable) and 1 change to a new IOCTL
that was introduced to kernel 5.2 in the previous pull requests.

See the tag comment for more details.

Thanks,
Oded

The following changes since commit 8ea5b2abd07e2280a332bd9c1a7f4dd15b9b6c13:

  Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs (2019-05-09 19:35:41 -0700)

are available in the Git repository at:

  git://people.freedesktop.org/~gabbayo/linux tags/misc-habanalabs-fixes-2019-05-12

for you to fetch changes up to 6800914b3a6dc11a08e7143f981c110aee439110:

  habanalabs: fix debugfs code (2019-05-04 15:56:08 +0200)

----------------------------------------------------------------
This tag contains the following fixes:

- Halt debug engines when user process closes the FD. We can't allow the
  device to issue transactions for a user which doesn't exists anymore.

- Fix various security holes in debugfs API.

- Add a new opcode to the DEBUG IOCTL API. The opcode is designed
  for setting the device into and out of debug mode. Although not a fix
  per-se, because this is a new IOCTL which is upstreamed in kernel 5.2, I
  think this is justified at this point because we won't be able to change
  the API later.

----------------------------------------------------------------
Jann Horn (1):
      habanalabs: fix debugfs code

Oded Gabbay (1):
      uapi/habanalabs: add opcode for enable/disable device debug mode

Omer Shpigelman (1):
      habanalabs: halt debug engines on user process close

 drivers/misc/habanalabs/context.c             |  6 +++
 drivers/misc/habanalabs/debugfs.c             | 60 ++++++++-------------------
 drivers/misc/habanalabs/goya/goya.c           |  3 +-
 drivers/misc/habanalabs/goya/goyaP.h          |  1 +
 drivers/misc/habanalabs/goya/goya_coresight.c | 17 ++++++++
 drivers/misc/habanalabs/habanalabs.h          |  2 +
 include/uapi/misc/habanalabs.h                | 22 +++++++++-
 7 files changed, 66 insertions(+), 45 deletions(-)

Re: [git pull] habanalabs fixes for 5.2-rc1/2

[Greg KH]

On Sun, May 12, 2019 at 10:41:36PM +0300, Oded Gabbay wrote:
> Hi Greg,
> 
> This is the pull request containing fixes for 5.2-rc1/2.
> 
> It contains 2 fixes (1 of them for stable) and 1 change to a new IOCTL
> that was introduced to kernel 5.2 in the previous pull requests.
> 
> See the tag comment for more details.
> 
> Thanks,
> Oded
> 
> The following changes since commit 8ea5b2abd07e2280a332bd9c1a7f4dd15b9b6c13:
> 
>   Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs (2019-05-09 19:35:41 -0700)
> 
> are available in the Git repository at:
> 
>   git://people.freedesktop.org/~gabbayo/linux tags/misc-habanalabs-fixes-2019-05-12

Is this pull request still needed, or was it also part of the other one?

How about fixing all of this by just sending patches?  :)

thanks,

greg k-h

Re: [git pull] habanalabs fixes for 5.2-rc1/2

[Oded Gabbay]

On Fri, May 24, 2019 at 9:36 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sun, May 12, 2019 at 10:41:36PM +0300, Oded Gabbay wrote:
> > Hi Greg,
> >
> > This is the pull request containing fixes for 5.2-rc1/2.
> >
> > It contains 2 fixes (1 of them for stable) and 1 change to a new IOCTL
> > that was introduced to kernel 5.2 in the previous pull requests.
> >
> > See the tag comment for more details.
> >
> > Thanks,
> > Oded
> >
> > The following changes since commit 8ea5b2abd07e2280a332bd9c1a7f4dd15b9b6c13:
> >
> >   Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs (2019-05-09 19:35:41 -0700)
> >
> > are available in the Git repository at:
> >
> >   git://people.freedesktop.org/~gabbayo/linux tags/misc-habanalabs-fixes-2019-05-12
>
> Is this pull request still needed, or was it also part of the other one?
not needed, I've sent you a new one that includes this and I wrote it
in the pull request.

>
> How about fixing all of this by just sending patches?  :)
Starting of next week, all my team members are starting to send
patches individually upstream, and I really think the right way to go
is for me to apply them to my -next and -fixes branches and then I
will send it to you at the appropriate time and to the correct
branches.
I'm sorry for the confusion that was here (I sent the fixes pull too
early), but I assure you it won't happen again.
Oded

>
> thanks,
>
> greg k-h