linux-next: Fixes tags need some work in the sound-asoc tree

linux-next: Fixes tags need some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2371 bytes --]

Hi all,

In commit

  be1b577d0178 ("ASoC: SOF: Intel: hda: fix the hda init chip")

Fixes tag

  Fixes: 8a300c8fb17 ("ASoC: SOF: Intel: Add HDA controller for Intel DSP")

has these problem(s):

  - SHA1 should be at least 12 digits long

In commit

  1183e9a634db ("ASoC: SOF: ipc: fix a race, leading to IPC timeouts")

Fixes tag

  Fixes: 53e0c72d98b ("ASoC: SOF: Add support for IPC IO between DSP and Host")

has these problem(s):

  - SHA1 should be at least 12 digits long

In commit

  5661ad9490ee ("ASoC: SOF: control: correct the copy size for bytes kcontrol put")

Fixes tag

  Fixes: c3078f53970 ("ASoC: SOF: Add Sound Open Firmware KControl support")

has these problem(s):

  - SHA1 should be at least 12 digits long

In commit

  fab4edf42d2d ("ASoC: SOF: pcm: remove warning - initialize workqueue on open")

Fixes tag

  Fixes: e2803e610ae ("ASoC: SOF: PCM: add period_elapsed work to fix

has these problem(s):

  - SHA1 should be at least 12 digits long
  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes
Please do not split Fixes tags over more than one line.

In commit

  04ea642ff62a ("ASoC: SOF: pcm: clear hw_params_upon_resume flag correctly")

Fixes tag

  Fixes: 868bd00f495 ("ASoC: SOF: Add PCM operations support")

has these problem(s):

  - SHA1 should be at least 12 digits long

In commit

  0bce512e784d ("ASoC: SOF: core: fix error handling with the probe workqueue")

Fixes tag

  Fixes: c16211d6226 ("ASoC: SOF: Add Sound Open Firmware driver core")

has these problem(s):

  - SHA1 should be at least 12 digits long

In commit

  13931ae31b67 ("ASoC: SOF: core: remove snd_soc_unregister_component in case of error")

Fixes tag

  Fixes: c16211d6226 ("ASoC: SOF: Add Sound Open Firmware driver core")

has these problem(s):

  - SHA1 should be at least 12 digits long

In commit

  b85459aafae6 ("ASoC: SOF: core: remove DSP after unregistering machine driver")

Fixes tag

  Fixes: c16211d6226 ("ASoC: SOF: Add Sound Open Firmware driver core")

has these problem(s):

  - SHA1 should be at least 12 digits long

Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tags need some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 110 bytes --]

Hi Mark,

This should have referred to the sound-asoc-fixes tree, sorry.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tags need some work in the sound-asoc tree

[Pierre-Louis Bossart]

On 5/28/19 4:56 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    be1b577d0178 ("ASoC: SOF: Intel: hda: fix the hda init chip")
> 
> Fixes tag
> 
>    Fixes: 8a300c8fb17 ("ASoC: SOF: Intel: Add HDA controller for Intel DSP")

Sorry about that, not sure how I managed to add an off-by-one in all 
these tags. Checkpatch.pl --strict did not report any issues, something 
must be broken either in my setup or the script.
Not sure how I can fix this now?

Re: linux-next: Fixes tags need some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

Hi Pierre-Louis,

On Tue, 28 May 2019 17:22:40 -0500 Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> wrote:
>
> On 5/28/19 4:56 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >    be1b577d0178 ("ASoC: SOF: Intel: hda: fix the hda init chip")
> > 
> > Fixes tag
> > 
> >    Fixes: 8a300c8fb17 ("ASoC: SOF: Intel: Add HDA controller for Intel DSP")  
> 
> Sorry about that, not sure how I managed to add an off-by-one in all 
> these tags. Checkpatch.pl --strict did not report any issues, something 
> must be broken either in my setup or the script.
> Not sure how I can fix this now?

Its not worth the rebase necessary to fix them.  Just use it as a
learning experience.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tags need some work in the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

Hi all,

In commit

  b4ed6b51f356 ("ASoC: core: conditionally increase module refcount on component open")

Fixes tag

  Fixes: b450b878('ASoC: core: don't increase component module refcount

has these problem(s):

  - missing space between the SHA1 and the subject
  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").
  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not wrap FIxes tags over more than one line.


In commit

  17d3069ccf06 ("ASoC: stm32: fix sai driver name initialisation")

Fixes tag

  Fixes: 3e086ed ("ASoC: stm32: add SAI driver")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]