From: Lee Jones <lee.jones@linaro.org>
To: Stefan Mavrodiev <stefan@olimex.com>
Cc: Heiko Stuebner <heiko@sntech.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] mfd: rk808: Prepare rk805 for poweroff
Date: Wed, 12 Jun 2019 10:41:42 +0100 [thread overview]
Message-ID: <20190612094142.GH4797@dell> (raw)
In-Reply-To: <20190607124226.17694-3-stefan@olimex.com>
On Fri, 07 Jun 2019, Stefan Mavrodiev wrote:
> RK805 has SLEEP signal, which can put the device into SLEEP or OFF
> mode. The default is SLEEP mode.
>
> However, when the kernel performs power-off (actually the ATF) the
> device will not go fully off and this will result in higher power
> consumption and inability to wake the device with RTC alarm.
>
> The solution is to enable pm_power_off_prepare function, which will
> configure SLEEP pin for OFF function.
>
> Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
> ---
> Change for v3:
> - Remove useless warning messages
> - Change poweroff error messages
> - Add explanation comments
> Changes for v2:
> - Move pm_pwroff_prep_fn to header
> - Check pm_power_off_prepare before make it NULL
>
> drivers/mfd/rk808.c | 50 +++++++++++++++++++++++++++------------
> include/linux/mfd/rk808.h | 1 +
> 2 files changed, 36 insertions(+), 15 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2019-06-12 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 12:42 [PATCH v3 0/2] mfd: rk808: Fix pointers and poweroff Stefan Mavrodiev
2019-06-07 12:42 ` [PATCH v3 1/2] mfd: rk808: Check pm_power_off pointer Stefan Mavrodiev
2019-06-12 9:41 ` Lee Jones
2019-06-07 12:42 ` [PATCH v3 2/2] mfd: rk808: Prepare rk805 for poweroff Stefan Mavrodiev
2019-06-12 9:41 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612094142.GH4797@dell \
--to=lee.jones@linaro.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan@olimex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox