[PATCH 0/3] drivers: slimbus: patches for 5.3

[PATCH 0/3] drivers: slimbus: patches for 5.3

[Srinivas Kandagatla]

Hi Greg, 
Here are some slimbus patches that are good to go in 5.3

One of them is doc fix and other one is redundant message
and the last one is fix for module autoloading which have dt entry.

Thanks,
srini

Ding Xiang (1):
  slimbus: remove redundant dev_err message

Jonathan Corbet (1):
  slimbus: fix kerneldoc comments

Srinivas Kandagatla (1):
  slimbus: core: generate uevent for non-dt only

 drivers/slimbus/core.c      |  5 -----
 drivers/slimbus/qcom-ctrl.c |  4 +---
 drivers/slimbus/stream.c    | 12 ++++++------
 3 files changed, 7 insertions(+), 14 deletions(-)

-- 
2.21.0

[PATCH 1/3] slimbus: fix kerneldoc comments

[Srinivas Kandagatla]

From: Jonathan Corbet <corbet@lwn.net>

The kerneldoc comments in drivers/slimbus/stream.c were not properly
formatted, leading to a distinctly unsatisfying "no structured comments
found" warning in the docs build.  Sprinkle some asterisks around so that
the comments will be properly recognized.

Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/slimbus/stream.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/slimbus/stream.c b/drivers/slimbus/stream.c
index 2fa05324ed07..75f87b3d8b95 100644
--- a/drivers/slimbus/stream.c
+++ b/drivers/slimbus/stream.c
@@ -84,7 +84,7 @@ static const int slim_presence_rate_table[] = {
 	512000,
 };
 
-/*
+/**
  * slim_stream_allocate() - Allocate a new SLIMbus Stream
  * @dev:Slim device to be associated with
  * @name: name of the stream
@@ -189,7 +189,7 @@ static int slim_get_prate_code(int rate)
 	return -EINVAL;
 }
 
-/*
+/**
  * slim_stream_prepare() - Prepare a SLIMbus Stream
  *
  * @rt: instance of slim stream runtime to configure
@@ -336,7 +336,7 @@ static int slim_activate_channel(struct slim_stream_runtime *stream,
 	return slim_do_transfer(sdev->ctrl, &txn);
 }
 
-/*
+/**
  * slim_stream_enable() - Enable a prepared SLIMbus Stream
  *
  * @stream: instance of slim stream runtime to enable
@@ -389,7 +389,7 @@ int slim_stream_enable(struct slim_stream_runtime *stream)
 }
 EXPORT_SYMBOL_GPL(slim_stream_enable);
 
-/*
+/**
  * slim_stream_disable() - Disable a SLIMbus Stream
  *
  * @stream: instance of slim stream runtime to disable
@@ -423,7 +423,7 @@ int slim_stream_disable(struct slim_stream_runtime *stream)
 }
 EXPORT_SYMBOL_GPL(slim_stream_disable);
 
-/*
+/**
  * slim_stream_unprepare() - Un-prepare a SLIMbus Stream
  *
  * @stream: instance of slim stream runtime to unprepare
@@ -449,7 +449,7 @@ int slim_stream_unprepare(struct slim_stream_runtime *stream)
 }
 EXPORT_SYMBOL_GPL(slim_stream_unprepare);
 
-/*
+/**
  * slim_stream_free() - Free a SLIMbus Stream
  *
  * @stream: instance of slim stream runtime to free
-- 
2.21.0

[PATCH 2/3] slimbus: remove redundant dev_err message

[Srinivas Kandagatla]

From: Ding Xiang <dingxiang@cmss.chinamobile.com>

devm_ioremap_resource already contains error message, so remove
the redundant dev_err message

Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/slimbus/qcom-ctrl.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
index ad3e2e23f56e..a444badd8df5 100644
--- a/drivers/slimbus/qcom-ctrl.c
+++ b/drivers/slimbus/qcom-ctrl.c
@@ -528,10 +528,8 @@ static int qcom_slim_probe(struct platform_device *pdev)
 
 	slim_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ctrl");
 	ctrl->base = devm_ioremap_resource(ctrl->dev, slim_mem);
-	if (IS_ERR(ctrl->base)) {
-		dev_err(&pdev->dev, "IOremap failed\n");
+	if (IS_ERR(ctrl->base))
 		return PTR_ERR(ctrl->base);
-	}
 
 	sctrl->set_laddr = qcom_set_laddr;
 	sctrl->xfer_msg = qcom_xfer_msg;
-- 
2.21.0

[PATCH 3/3] slimbus: core: generate uevent for non-dt only

[Srinivas Kandagatla]

Rely on MODULE_ALIAS() for automatic kernel module loading, rather than
basing it on the OF compatible. This ensures that drivers without
of_device_id table, such as wcd9335, will be automatically loaded.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
[bjorn: Added commit message]
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 drivers/slimbus/core.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
index b2f07d2043eb..526e3215d8fe 100644
--- a/drivers/slimbus/core.c
+++ b/drivers/slimbus/core.c
@@ -98,11 +98,6 @@ static int slim_device_remove(struct device *dev)
 static int slim_device_uevent(struct device *dev, struct kobj_uevent_env *env)
 {
 	struct slim_device *sbdev = to_slim_device(dev);
-	int ret;
-
-	ret = of_device_uevent_modalias(dev, env);
-	if (ret != -ENODEV)
-		return ret;
 
 	return add_uevent_var(env, "MODALIAS=slim:%s", dev_name(&sbdev->dev));
 }
-- 
2.21.0

Re: [PATCH 1/3] slimbus: fix kerneldoc comments

[Greg KH]

On Thu, Jun 20, 2019 at 09:11:27AM +0100, Srinivas Kandagatla wrote:
> From: Jonathan Corbet <corbet@lwn.net>
> 
> The kerneldoc comments in drivers/slimbus/stream.c were not properly
> formatted, leading to a distinctly unsatisfying "no structured comments
> found" warning in the docs build.  Sprinkle some asterisks around so that
> the comments will be properly recognized.
> 
> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  drivers/slimbus/stream.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Turns out this was already in my tree :)

Also, when sending out patches, be sure to cc: the authors, no need to
suppress that in git send-email.

thanks,

greg k-h

Re: [PATCH 1/3] slimbus: fix kerneldoc comments

[Srinivas Kandagatla]

On 20/06/2019 09:46, Greg KH wrote:
> On Thu, Jun 20, 2019 at 09:11:27AM +0100, Srinivas Kandagatla wrote:
>> From: Jonathan Corbet <corbet@lwn.net>
>>
>> The kerneldoc comments in drivers/slimbus/stream.c were not properly
>> formatted, leading to a distinctly unsatisfying "no structured comments
>> found" warning in the docs build.  Sprinkle some asterisks around so that
>> the comments will be properly recognized.
>>
>> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>>   drivers/slimbus/stream.c | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> Turns out this was already in my tree :)
>
Ah, I should have rebased it on top of char-misc!


> Also, when sending out patches, be sure to cc: the authors, no need to
> suppress that in git send-email.
> 
Sure, I will keep that in mind!

thanks,
srini
> thanks,
> 
> greg k-h
>