From: Christoph Hellwig <hch@lst.de>
To: Maxim Levitsky <mlevitsk@redhat.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@fb.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-nvme@lists.infradead.org, Paul Pawlowski <paul@mrarm.io>
Subject: Re: [PATCH] nvme: Add support for Apple 2018+ models
Date: Mon, 15 Jul 2019 14:29:53 +0200 [thread overview]
Message-ID: <20190715122953.GB3937@lst.de> (raw)
In-Reply-To: <4caeb954b2fa91445e02bac7ac9610ca886b4dd8.camel@redhat.com>
On Mon, Jul 15, 2019 at 12:28:05PM +0300, Maxim Levitsky wrote:
>
> To be honest, the spec explicitly states that minimum submission queue entry size is 64
> and minimum completion entry size should be is 16 bytes for NVM command set:
That doesn't keep Apple from implementing whatever they want and soldering
that down on their MacBook mainboards unfortunately :(
prev parent reply other threads:[~2019-07-15 12:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 3:43 [PATCH] nvme: Add support for Apple 2018+ models Benjamin Herrenschmidt
2019-07-15 8:10 ` Christoph Hellwig
2019-07-15 8:43 ` Benjamin Herrenschmidt
2019-07-15 9:03 ` Benjamin Herrenschmidt
2019-07-15 9:28 ` Maxim Levitsky
2019-07-15 10:01 ` Benjamin Herrenschmidt
2019-07-15 12:29 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715122953.GB3937@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=benh@kernel.crashing.org \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mlevitsk@redhat.com \
--cc=paul@mrarm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox