* [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Avoid fall-through warning
@ 2019-07-22 17:47 Gustavo A. R. Silva
2019-07-22 18:14 ` Liu, Shaoyun
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-22 17:47 UTC (permalink / raw)
To: Cox, Philip, Liu, Shaoyun, Oded Gabbay, Alex Deucher,
Christian König, David (ChunMing) Zhou, David Airlie,
Daniel Vetter
Cc: dri-devel, amd-gfx, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, this patch silences
the following warning:
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_mqd_manager_v10.c: In function ‘mqd_manager_init_v10’:
./include/linux/dynamic_debug.h:122:52: warning: this statement may fall through [-Wimplicit-fallthrough=]
#define __dynamic_func_call(id, fmt, func, ...) do { \
^
./include/linux/dynamic_debug.h:143:2: note: in expansion of macro ‘__dynamic_func_call’
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~
./include/linux/dynamic_debug.h:153:2: note: in expansion of macro ‘_dynamic_func_call’
_dynamic_func_call(fmt, __dynamic_pr_debug, \
^~~~~~~~~~~~~~~~~~
./include/linux/printk.h:336:2: note: in expansion of macro ‘dynamic_pr_debug’
dynamic_pr_debug(fmt, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_mqd_manager_v10.c:432:3: note: in expansion of macro ‘pr_debug’
pr_debug("%s@%i\n", __func__, __LINE__);
^~~~~~~~
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_mqd_manager_v10.c:433:2: note: here
case KFD_MQD_TYPE_COMPUTE:
^~~~
by removing the call to pr_debug() in KFD_MQD_TYPE_CP:
"The mqd init for CP and COMPUTE will have the same routine." [1]
This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.
[1] https://lore.kernel.org/lkml/c735a1cc-a545-50fb-44e7-c0ad93ee8ee7@amd.com/
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c
index 4f8a6ffc5775..9cd3eb2d90bd 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c
@@ -429,7 +429,6 @@ struct mqd_manager *mqd_manager_init_v10(enum KFD_MQD_TYPE type,
switch (type) {
case KFD_MQD_TYPE_CP:
- pr_debug("%s@%i\n", __func__, __LINE__);
case KFD_MQD_TYPE_COMPUTE:
pr_debug("%s@%i\n", __func__, __LINE__);
mqd->allocate_mqd = allocate_mqd;
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Avoid fall-through warning
2019-07-22 17:47 [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Avoid fall-through warning Gustavo A. R. Silva
@ 2019-07-22 18:14 ` Liu, Shaoyun
2019-07-22 19:13 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Liu, Shaoyun @ 2019-07-22 18:14 UTC (permalink / raw)
To: Gustavo A. R. Silva, Cox, Philip, Oded Gabbay, Deucher, Alexander,
Koenig, Christian, Zhou, David(ChunMing), David Airlie,
Daniel Vetter
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Reviewed-by: shaoyunl <shaoyun.liu@amd.com>
On 2019-07-22 1:47 p.m., Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, this patch silences
> the following warning:
>
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_mqd_manager_v10.c: In function ‘mqd_manager_init_v10’:
> ./include/linux/dynamic_debug.h:122:52: warning: this statement may fall through [-Wimplicit-fallthrough=]
> #define __dynamic_func_call(id, fmt, func, ...) do { \
> ^
> ./include/linux/dynamic_debug.h:143:2: note: in expansion of macro ‘__dynamic_func_call’
> __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
> ^~~~~~~~~~~~~~~~~~~
> ./include/linux/dynamic_debug.h:153:2: note: in expansion of macro ‘_dynamic_func_call’
> _dynamic_func_call(fmt, __dynamic_pr_debug, \
> ^~~~~~~~~~~~~~~~~~
> ./include/linux/printk.h:336:2: note: in expansion of macro ‘dynamic_pr_debug’
> dynamic_pr_debug(fmt, ##__VA_ARGS__)
> ^~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_mqd_manager_v10.c:432:3: note: in expansion of macro ‘pr_debug’
> pr_debug("%s@%i\n", __func__, __LINE__);
> ^~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_mqd_manager_v10.c:433:2: note: here
> case KFD_MQD_TYPE_COMPUTE:
> ^~~~
>
> by removing the call to pr_debug() in KFD_MQD_TYPE_CP:
>
> "The mqd init for CP and COMPUTE will have the same routine." [1]
>
> This bug was found thanks to the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> [1] https://lore.kernel.org/lkml/c735a1cc-a545-50fb-44e7-c0ad93ee8ee7@amd.com/
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c
> index 4f8a6ffc5775..9cd3eb2d90bd 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c
> @@ -429,7 +429,6 @@ struct mqd_manager *mqd_manager_init_v10(enum KFD_MQD_TYPE type,
>
> switch (type) {
> case KFD_MQD_TYPE_CP:
> - pr_debug("%s@%i\n", __func__, __LINE__);
> case KFD_MQD_TYPE_COMPUTE:
> pr_debug("%s@%i\n", __func__, __LINE__);
> mqd->allocate_mqd = allocate_mqd;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Avoid fall-through warning
2019-07-22 18:14 ` Liu, Shaoyun
@ 2019-07-22 19:13 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2019-07-22 19:13 UTC (permalink / raw)
To: Liu, Shaoyun
Cc: Gustavo A. R. Silva, Cox, Philip, Oded Gabbay, Deucher, Alexander,
Koenig, Christian, Zhou, David(ChunMing), David Airlie,
Daniel Vetter, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Applied. Thanks!
Alex
On Mon, Jul 22, 2019 at 2:14 PM Liu, Shaoyun <Shaoyun.Liu@amd.com> wrote:
>
> Reviewed-by: shaoyunl <shaoyun.liu@amd.com>
>
> On 2019-07-22 1:47 p.m., Gustavo A. R. Silva wrote:
> > In preparation to enabling -Wimplicit-fallthrough, this patch silences
> > the following warning:
> >
> > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_mqd_manager_v10.c: In function ‘mqd_manager_init_v10’:
> > ./include/linux/dynamic_debug.h:122:52: warning: this statement may fall through [-Wimplicit-fallthrough=]
> > #define __dynamic_func_call(id, fmt, func, ...) do { \
> > ^
> > ./include/linux/dynamic_debug.h:143:2: note: in expansion of macro ‘__dynamic_func_call’
> > __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
> > ^~~~~~~~~~~~~~~~~~~
> > ./include/linux/dynamic_debug.h:153:2: note: in expansion of macro ‘_dynamic_func_call’
> > _dynamic_func_call(fmt, __dynamic_pr_debug, \
> > ^~~~~~~~~~~~~~~~~~
> > ./include/linux/printk.h:336:2: note: in expansion of macro ‘dynamic_pr_debug’
> > dynamic_pr_debug(fmt, ##__VA_ARGS__)
> > ^~~~~~~~~~~~~~~~
> > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_mqd_manager_v10.c:432:3: note: in expansion of macro ‘pr_debug’
> > pr_debug("%s@%i\n", __func__, __LINE__);
> > ^~~~~~~~
> > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_mqd_manager_v10.c:433:2: note: here
> > case KFD_MQD_TYPE_COMPUTE:
> > ^~~~
> >
> > by removing the call to pr_debug() in KFD_MQD_TYPE_CP:
> >
> > "The mqd init for CP and COMPUTE will have the same routine." [1]
> >
> > This bug was found thanks to the ongoing efforts to enable
> > -Wimplicit-fallthrough.
> >
> > [1] https://lore.kernel.org/lkml/c735a1cc-a545-50fb-44e7-c0ad93ee8ee7@amd.com/
> >
> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> > ---
> > drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c
> > index 4f8a6ffc5775..9cd3eb2d90bd 100644
> > --- a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c
> > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c
> > @@ -429,7 +429,6 @@ struct mqd_manager *mqd_manager_init_v10(enum KFD_MQD_TYPE type,
> >
> > switch (type) {
> > case KFD_MQD_TYPE_CP:
> > - pr_debug("%s@%i\n", __func__, __LINE__);
> > case KFD_MQD_TYPE_COMPUTE:
> > pr_debug("%s@%i\n", __func__, __LINE__);
> > mqd->allocate_mqd = allocate_mqd;
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-22 19:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-22 17:47 [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Avoid fall-through warning Gustavo A. R. Silva
2019-07-22 18:14 ` Liu, Shaoyun
2019-07-22 19:13 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox