* [PATCH -next] staging: rtl8723bs: remove unnecessary null check
@ 2019-10-15 11:40 YueHaibing
2019-10-15 11:46 ` Dan Carpenter
2019-10-15 11:55 ` [PATCH v2 " YueHaibing
0 siblings, 2 replies; 4+ messages in thread
From: YueHaibing @ 2019-10-15 11:40 UTC (permalink / raw)
To: gregkh, jarias.linux, julia.lawall, colin.king, hdegoede,
hariprasad.kelam, nachukannan, pakki001, hardiksingh.k,
nishkadg.linux
Cc: devel, linux-kernel, YueHaibing
Null check before kfree is redundant, so remove it.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 7011c2a..4597f4f 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -2210,8 +2210,7 @@ void rtw_free_hwxmits(struct adapter *padapter)
struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
hwxmits = pxmitpriv->hwxmits;
- if (hwxmits)
- kfree(hwxmits);
+ kfree(hwxmits);
}
void rtw_init_hwxmits(struct hw_xmit *phwxmit, sint entry)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] staging: rtl8723bs: remove unnecessary null check
2019-10-15 11:40 [PATCH -next] staging: rtl8723bs: remove unnecessary null check YueHaibing
@ 2019-10-15 11:46 ` Dan Carpenter
2019-10-15 11:55 ` [PATCH v2 " YueHaibing
1 sibling, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2019-10-15 11:46 UTC (permalink / raw)
To: YueHaibing
Cc: gregkh, jarias.linux, julia.lawall, colin.king, hdegoede,
hariprasad.kelam, nachukannan, pakki001, hardiksingh.k,
nishkadg.linux, devel, linux-kernel
On Tue, Oct 15, 2019 at 07:40:53PM +0800, YueHaibing wrote:
> Null check before kfree is redundant, so remove it.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> index 7011c2a..4597f4f 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> @@ -2210,8 +2210,7 @@ void rtw_free_hwxmits(struct adapter *padapter)
> struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
>
> hwxmits = pxmitpriv->hwxmits;
> - if (hwxmits)
> - kfree(hwxmits);
> + kfree(hwxmits);
Just do:
kfree(pxmitpriv->hwxmits);
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 -next] staging: rtl8723bs: remove unnecessary null check
2019-10-15 11:40 [PATCH -next] staging: rtl8723bs: remove unnecessary null check YueHaibing
2019-10-15 11:46 ` Dan Carpenter
@ 2019-10-15 11:55 ` YueHaibing
1 sibling, 0 replies; 4+ messages in thread
From: YueHaibing @ 2019-10-15 11:55 UTC (permalink / raw)
To: gregkh, jarias.linux, julia.lawall, colin.king, hdegoede,
hariprasad.kelam, nachukannan, pakki001, hardiksingh.k,
nishkadg.linux, dan.carpenter
Cc: devel, linux-kernel, YueHaibing
Null check before kfree is redundant, so remove it.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: remove unnecessary 'hwxmits'
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 7011c2a..6d193f1 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -2206,12 +2206,9 @@ s32 rtw_alloc_hwxmits(struct adapter *padapter)
void rtw_free_hwxmits(struct adapter *padapter)
{
- struct hw_xmit *hwxmits;
struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
- hwxmits = pxmitpriv->hwxmits;
- if (hwxmits)
- kfree(hwxmits);
+ kfree(pxmitpriv->hwxmits);
}
void rtw_init_hwxmits(struct hw_xmit *phwxmit, sint entry)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] staging: rtl8723bs: Remove unnecessary null check
@ 2019-10-10 15:33 YueHaibing
0 siblings, 0 replies; 4+ messages in thread
From: YueHaibing @ 2019-10-10 15:33 UTC (permalink / raw)
To: gregkh, shobhitkukreti, hariprasad.kelam, benniciemanuel78,
nishkadg.linux, madhumithabiw, arnd, kai.heng.feng
Cc: devel, linux-kernel, YueHaibing
Null check before kfree is redundant, so remove it.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 5044f73..74b097a 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -1141,8 +1141,7 @@ void rtw_ndev_destructor(struct net_device *ndev)
{
DBG_871X(FUNC_NDEV_FMT "\n", FUNC_NDEV_ARG(ndev));
- if (ndev->ieee80211_ptr)
- kfree(ndev->ieee80211_ptr);
+ kfree(ndev->ieee80211_ptr);
}
void rtw_dev_unload(struct adapter *padapter)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-15 11:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-15 11:40 [PATCH -next] staging: rtl8723bs: remove unnecessary null check YueHaibing
2019-10-15 11:46 ` Dan Carpenter
2019-10-15 11:55 ` [PATCH v2 " YueHaibing
-- strict thread matches above, loose matches on Subject: below --
2019-10-10 15:33 [PATCH -next] staging: rtl8723bs: Remove " YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox