* [PATCH v2] arm64: print additional fault message when executing non-exec memory
@ 2019-10-29 12:41 Xiang Zheng
2019-10-29 13:36 ` Will Deacon
2019-10-29 15:41 ` Catalin Marinas
0 siblings, 2 replies; 3+ messages in thread
From: Xiang Zheng @ 2019-10-29 12:41 UTC (permalink / raw)
To: catalin.marinas, will
Cc: james.morse, linux-arm-kernel, linux-kernel, wanghaibin.wang
When attempting to executing non-executable memory, the fault message
shows:
Unable to handle kernel read from unreadable memory at virtual address
ffff802dac469000
This may confuse someone, so add a new fault message for instruction
abort.
Signed-off-by: Xiang Zheng <zhengxiang9@huawei.com>
---
arch/arm64/mm/fault.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
index 9fc6db0bcbad..9adec86d0f8a 100644
--- a/arch/arm64/mm/fault.c
+++ b/arch/arm64/mm/fault.c
@@ -318,6 +318,8 @@ static void __do_kernel_fault(unsigned long addr, unsigned int esr,
if (is_el1_permission_fault(addr, esr, regs)) {
if (esr & ESR_ELx_WNR)
msg = "write to read-only memory";
+ else if (is_el1_instruction_abort(esr))
+ msg = "execute from non-executable memory";
else
msg = "read from unreadable memory";
} else if (addr < PAGE_SIZE) {
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: print additional fault message when executing non-exec memory
2019-10-29 12:41 [PATCH v2] arm64: print additional fault message when executing non-exec memory Xiang Zheng
@ 2019-10-29 13:36 ` Will Deacon
2019-10-29 15:41 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2019-10-29 13:36 UTC (permalink / raw)
To: Xiang Zheng
Cc: catalin.marinas, james.morse, linux-arm-kernel, linux-kernel,
wanghaibin.wang
On Tue, Oct 29, 2019 at 08:41:31PM +0800, Xiang Zheng wrote:
> When attempting to executing non-executable memory, the fault message
> shows:
>
> Unable to handle kernel read from unreadable memory at virtual address
> ffff802dac469000
>
> This may confuse someone, so add a new fault message for instruction
> abort.
>
> Signed-off-by: Xiang Zheng <zhengxiang9@huawei.com>
> ---
> arch/arm64/mm/fault.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 9fc6db0bcbad..9adec86d0f8a 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -318,6 +318,8 @@ static void __do_kernel_fault(unsigned long addr, unsigned int esr,
> if (is_el1_permission_fault(addr, esr, regs)) {
> if (esr & ESR_ELx_WNR)
> msg = "write to read-only memory";
> + else if (is_el1_instruction_abort(esr))
> + msg = "execute from non-executable memory";
> else
> msg = "read from unreadable memory";
> } else if (addr < PAGE_SIZE) {
Acked-by: Will Deacon <will@kernel.org>
Will
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: print additional fault message when executing non-exec memory
2019-10-29 12:41 [PATCH v2] arm64: print additional fault message when executing non-exec memory Xiang Zheng
2019-10-29 13:36 ` Will Deacon
@ 2019-10-29 15:41 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2019-10-29 15:41 UTC (permalink / raw)
To: Xiang Zheng
Cc: will, james.morse, linux-arm-kernel, linux-kernel,
wanghaibin.wang
On Tue, Oct 29, 2019 at 08:41:31PM +0800, Xiang Zheng wrote:
> When attempting to executing non-executable memory, the fault message
> shows:
>
> Unable to handle kernel read from unreadable memory at virtual address
> ffff802dac469000
>
> This may confuse someone, so add a new fault message for instruction
> abort.
>
> Signed-off-by: Xiang Zheng <zhengxiang9@huawei.com>
Queued for 5.5. Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-29 15:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-29 12:41 [PATCH v2] arm64: print additional fault message when executing non-exec memory Xiang Zheng
2019-10-29 13:36 ` Will Deacon
2019-10-29 15:41 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox