From: Frederic Weisbecker <frederic@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/4] irq_work: Convert flags to atomic_t
Date: Mon, 11 Nov 2019 23:56:11 +0100 [thread overview]
Message-ID: <20191111225610.GB27917@lenoir> (raw)
In-Reply-To: <20191111080058.GA72562@gmail.com>
On Mon, Nov 11, 2019 at 09:00:58AM +0100, Ingo Molnar wrote:
>
> * Frederic Weisbecker <frederic@kernel.org> wrote:
>
> > We need to convert flags to atomic_t in order to later fix an ordering
> > issue on cmpxchg() failure. This will allow us to use atomic_fetch_or().
> > Also that clarify the nature of those flags.
> >
> > Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> > Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Ingo Molnar <mingo@kernel.org>
> > ---
> > include/linux/irq_work.h | 10 +++++++---
> > kernel/irq_work.c | 18 +++++++++---------
> > kernel/printk/printk.c | 2 +-
> > 3 files changed, 17 insertions(+), 13 deletions(-)
>
> You missed the irq_work use in kernel/bpf/stackmap.c - see the fix below.
>
> Thanks,
>
> Ingo
Oh thanks. Strange that I haven't seen a 0-day warning about those.
next prev parent reply other threads:[~2019-11-11 22:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 16:08 [PATCH 0/4] irq_work: Fix ordering issue Frederic Weisbecker
2019-11-08 16:08 ` [PATCH 1/4] irq_work: Convert flags to atomic_t Frederic Weisbecker
2019-11-11 8:00 ` Ingo Molnar
2019-11-11 22:56 ` Frederic Weisbecker [this message]
2019-11-11 9:32 ` [tip: irq/core] " tip-bot2 for Frederic Weisbecker
2019-11-08 16:08 ` [PATCH 2/4] irq_work: Fix irq_work_claim() ordering Frederic Weisbecker
2019-11-11 7:20 ` Ingo Molnar
2019-11-11 23:17 ` Frederic Weisbecker
2019-11-11 9:32 ` [tip: irq/core] irq_work: Fix irq_work_claim() memory ordering tip-bot2 for Frederic Weisbecker
2019-11-08 16:08 ` [PATCH 3/4] irq_work: Slightly simplify IRQ_WORK_PENDING clearing Frederic Weisbecker
2019-11-11 9:32 ` [tip: irq/core] " tip-bot2 for Frederic Weisbecker
2019-11-12 20:27 ` [PATCH 3/4] " Leonard Crestez
2019-11-13 0:22 ` Frederic Weisbecker
2019-11-08 16:08 ` [RFC PATCH 4/4] irq_work: Weaken ordering in irq_work_run_list() Frederic Weisbecker
2019-11-11 8:43 ` Peter Zijlstra
2019-11-11 22:38 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111225610.GB27917@lenoir \
--to=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox