From: Andreas Kemnade <andreas@kemnade.info>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org, phh@phh.me,
b.galvani@gmail.com, stefan@agner.ch
Subject: Re: [PATCH] regulator: rn5t618: fix rc5t619 ldo10 enable
Date: Wed, 13 Nov 2019 20:26:33 +0100 [thread overview]
Message-ID: <20191113202633.66a91d96@aktux> (raw)
In-Reply-To: <20191113183211.GB4402@sirena.co.uk>
Hi,
On Wed, 13 Nov 2019 18:32:11 +0000
Mark Brown <broonie@kernel.org> wrote:
> On Wed, Nov 13, 2019 at 07:26:43PM +0100, Andreas Kemnade wrote:
> > LDO9 and LDO10 were listed with the same enable bits.
> > That looks insane and there are no provisions in the code for handling such
> > a special case. Also other out-of-tree drivers use a separate bit to
> > enable it.
>
> This definitely looks like a bug but without a datasheet or testing it's
> worrying guessing at the register bit to use for the enable for the
> second LDO...
I am hoping for a Tested-By: from the one who has submitted the patch
for the regulator.
Well, it is not just guessing, it is there in the url I referenced. But
I would of course prefer a better source. At first I wanted to spread
my findings.
I am not pushing anyone to accept it without Tested-By/Reviewed-Bys.
What is a good way to avoid people bumping into this bug?
Maybe I can find the right C on the board to check.
Regards,
Andreas
next prev parent reply other threads:[~2019-11-13 19:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 18:26 [PATCH] regulator: rn5t618: fix rc5t619 ldo10 enable Andreas Kemnade
2019-11-13 18:32 ` Mark Brown
2019-11-13 19:26 ` Andreas Kemnade [this message]
2019-11-14 11:54 ` Mark Brown
2019-11-14 12:13 ` Stefan Agner
2019-11-14 14:30 ` Andreas Kemnade
2019-11-14 14:24 ` Andreas Kemnade
2019-11-14 19:08 ` Mark Brown
2019-11-20 7:46 ` Pierre-Hugues Husson
2019-11-20 17:18 ` Applied "regulator: rn5t618: fix rc5t619 ldo10 enable" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113202633.66a91d96@aktux \
--to=andreas@kemnade.info \
--cc=b.galvani@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phh@phh.me \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox