From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
Lukas Wunner <lukas@wunner.de>,
Mario.Limonciello@dell.com,
Christian Kellner <ckellner@redhat.com>, zang <dump@tzib.net>
Subject: Re: [PATCH] thunderbolt: Power cycle the router if NVM authentication fails
Date: Fri, 15 Nov 2019 13:56:07 +0200 [thread overview]
Message-ID: <20191115115607.GA34425@lahna.fi.intel.com> (raw)
In-Reply-To: <20191112092452.70789-1-mika.westerberg@linux.intel.com>
On Tue, Nov 12, 2019 at 12:24:52PM +0300, Mika Westerberg wrote:
> On zang's Dell XPS 13 9370 after Thunderbolt NVM firmware upgrade the
> Thunderbolt controller did not come back as expected. Only after the
> system was rebooted it became available again. It is not entirely clear
> what happened but I suspect the new NVM firmware image authentication
> failed for some reason. Regardless of this the router needs to be power
> cycled if NVM authentication fails in order to get it fully functional
> again.
>
> This modifies the driver to issue a power cycle in case the NVM
> authentication fails immediately when dma_port_flash_update_auth()
> returns. We also need to call tb_switch_set_uuid() earlier to be able to
> fetch possible NVM authentication failure when DMA port is added.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=205457
> Reported-by: zang <dump@tzib.net>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> This applies on top of my thunderbolt.git/next.
Applied to thunderbolt.git/next.
prev parent reply other threads:[~2019-11-15 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 9:24 [PATCH] thunderbolt: Power cycle the router if NVM authentication fails Mika Westerberg
2019-11-15 11:56 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115115607.GA34425@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Mario.Limonciello@dell.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=ckellner@redhat.com \
--cc=dump@tzib.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.jamet@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox