* [PATCH] Input: goodix - support gt9147 touchpanel
@ 2019-11-27 10:28 Yannick Fertre
2019-12-01 3:08 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Yannick Fertre @ 2019-11-27 10:28 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard, Bastien Nocera,
Dmitry Torokhov, linux-input, linux-kernel
From: Yannick Fertré <yannick.fertre@st.com>
Add support for it by adding compatible and supported chip data
(default settings used).
The chip data on GT9147 is similar to GT912, like
- config data register has 0x8047 address
- config data register max len is 240
- config data checksum has 8-bit
Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
---
drivers/input/touchscreen/goodix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index fb43aa7..b470773 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -1045,6 +1045,7 @@ static const struct of_device_id goodix_of_match[] = {
{ .compatible = "goodix,gt9271" },
{ .compatible = "goodix,gt928" },
{ .compatible = "goodix,gt967" },
+ { .compatible = "goodix,gt9147",},
{ }
};
MODULE_DEVICE_TABLE(of, goodix_of_match);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Input: goodix - support gt9147 touchpanel
2019-11-27 10:28 [PATCH] Input: goodix - support gt9147 touchpanel Yannick Fertre
@ 2019-12-01 3:08 ` Dmitry Torokhov
2019-12-05 8:30 ` Yannick FERTRE
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2019-12-01 3:08 UTC (permalink / raw)
To: Yannick Fertre, Rob Herring
Cc: Philippe Cornu, Benjamin Gaignard, Bastien Nocera, linux-input,
linux-kernel
On Wed, Nov 27, 2019 at 11:28:46AM +0100, Yannick Fertre wrote:
> From: Yannick Fertré <yannick.fertre@st.com>
>
> Add support for it by adding compatible and supported chip data
> (default settings used).
> The chip data on GT9147 is similar to GT912, like
> - config data register has 0x8047 address
> - config data register max len is 240
> - config data checksum has 8-bit
If it is compatible with gt912 then the driver does not need another
compatible in the code I think. Rob will tell more.
>
> Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
> ---
> drivers/input/touchscreen/goodix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
> index fb43aa7..b470773 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -1045,6 +1045,7 @@ static const struct of_device_id goodix_of_match[] = {
> { .compatible = "goodix,gt9271" },
> { .compatible = "goodix,gt928" },
> { .compatible = "goodix,gt967" },
> + { .compatible = "goodix,gt9147",},
> { }
> };
> MODULE_DEVICE_TABLE(of, goodix_of_match);
> --
> 2.7.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] Input: goodix - support gt9147 touchpanel
2019-12-01 3:08 ` Dmitry Torokhov
@ 2019-12-05 8:30 ` Yannick FERTRE
0 siblings, 0 replies; 4+ messages in thread
From: Yannick FERTRE @ 2019-12-05 8:30 UTC (permalink / raw)
To: Dmitry Torokhov, Rob Herring
Cc: Philippe CORNU, Benjamin GAIGNARD, Bastien Nocera,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Hello,
Dmitry,
I forgot to modify the binding to declare the new compatible "gt9147".
Rob,
can I modify the binding without converting it first to yaml?
Best regards
Yannick Fertré
-----Original Message-----
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Sent: dimanche 1 décembre 2019 04:08
To: Yannick FERTRE <yannick.fertre@st.com>; Rob Herring <robh+dt@kernel.org>
Cc: Philippe CORNU <philippe.cornu@st.com>; Benjamin GAIGNARD <benjamin.gaignard@st.com>; Bastien Nocera <hadess@hadess.net>; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: goodix - support gt9147 touchpanel
On Wed, Nov 27, 2019 at 11:28:46AM +0100, Yannick Fertre wrote:
> From: Yannick Fertré <yannick.fertre@st.com>
>
> Add support for it by adding compatible and supported chip data
> (default settings used).
> The chip data on GT9147 is similar to GT912, like
> - config data register has 0x8047 address
> - config data register max len is 240
> - config data checksum has 8-bit
If it is compatible with gt912 then the driver does not need another compatible in the code I think. Rob will tell more.
>
> Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
> ---
> drivers/input/touchscreen/goodix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/goodix.c
> b/drivers/input/touchscreen/goodix.c
> index fb43aa7..b470773 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -1045,6 +1045,7 @@ static const struct of_device_id goodix_of_match[] = {
> { .compatible = "goodix,gt9271" },
> { .compatible = "goodix,gt928" },
> { .compatible = "goodix,gt967" },
> + { .compatible = "goodix,gt9147",},
> { }
> };
> MODULE_DEVICE_TABLE(of, goodix_of_match);
> --
> 2.7.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Input: goodix - support gt9147 touchpanel
@ 2019-11-27 10:24 Yannick Fertre
0 siblings, 0 replies; 4+ messages in thread
From: Yannick Fertre @ 2019-11-27 10:24 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard, David Airlie,
Daniel Vetter, Maxime Coquelin, Alexandre Torgue, dri-devel,
linux-stm32, linux-arm-kernel, linux-kernel
From: Yannick Fertré <yannick.fertre@st.com>
Add support for it by adding compatible and supported chip data
(default settings used).
The chip data on GT9147 is similar to GT912, like
- config data register has 0x8047 address
- config data register max len is 240
- config data checksum has 8-bit
Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
---
drivers/input/touchscreen/goodix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index fb43aa7..b470773 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -1045,6 +1045,7 @@ static const struct of_device_id goodix_of_match[] = {
{ .compatible = "goodix,gt9271" },
{ .compatible = "goodix,gt928" },
{ .compatible = "goodix,gt967" },
+ { .compatible = "goodix,gt9147",},
{ }
};
MODULE_DEVICE_TABLE(of, goodix_of_match);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-05 8:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-27 10:28 [PATCH] Input: goodix - support gt9147 touchpanel Yannick Fertre
2019-12-01 3:08 ` Dmitry Torokhov
2019-12-05 8:30 ` Yannick FERTRE
-- strict thread matches above, loose matches on Subject: below --
2019-11-27 10:24 Yannick Fertre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox