From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Kirill Tkhai <ktkhai@virtuozzo.com>,
mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
bsegall@google.com, mgorman@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] sched: Micro optimization in pick_next_task() and in check_preempt_curr()
Date: Thu, 19 Dec 2019 14:53:50 +0100 [thread overview]
Message-ID: <20191219135350.GA2844@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20191219085042.0a29437b@gandalf.local.home>
On Thu, Dec 19, 2019 at 08:50:42AM -0500, Steven Rostedt wrote:
> On Thu, 19 Dec 2019 15:39:14 +0300
> Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
>
> > @@ -6569,6 +6558,11 @@ void __init sched_init(void)
> > unsigned long ptr = 0;
> > int i;
> >
> > + BUG_ON(&idle_sched_class > &fair_sched_class ||
> > + &fair_sched_class > &rt_sched_class ||
> > + &rt_sched_class > &dl_sched_class ||
> > + &dl_sched_class > &stop_sched_class);
> > +
>
> Can this be a BUILD_BUG_ON? These address should all be constants.
Nope, BUILD_BUG_ON() is for compile time constants, these are link time
constants.
next prev parent reply other threads:[~2019-12-19 13:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 12:39 [PATCH RFC] sched: Micro optimization in pick_next_task() and in check_preempt_curr() Kirill Tkhai
2019-12-19 13:12 ` Peter Zijlstra
2019-12-19 14:02 ` Peter Zijlstra
2019-12-19 14:25 ` Kirill Tkhai
2019-12-19 14:31 ` Kirill Tkhai
2019-12-19 14:43 ` Steven Rostedt
2019-12-19 14:46 ` Kirill Tkhai
2019-12-19 14:59 ` Steven Rostedt
2019-12-19 15:20 ` [PATCH v2] " Kirill Tkhai
2019-12-19 15:40 ` Steven Rostedt
2019-12-19 16:08 ` Kirill Tkhai
2019-12-19 16:22 ` Steven Rostedt
2019-12-19 20:16 ` Kirill Tkhai
2019-12-19 20:20 ` Steven Rostedt
2019-12-19 16:05 ` Steven Rostedt
2019-12-19 14:04 ` [Q] ld: Does LTO reorder ro variables in two files? Kirill Tkhai
2019-12-19 15:21 ` Jeff Law
2019-12-19 15:30 ` Kirill Tkhai
2019-12-19 15:45 ` Alexander Monakov
2019-12-19 16:08 ` Kirill Tkhai
2019-12-19 13:50 ` [PATCH RFC] sched: Micro optimization in pick_next_task() and in check_preempt_curr() Steven Rostedt
2019-12-19 13:53 ` Kirill Tkhai
2019-12-19 13:53 ` Peter Zijlstra [this message]
2020-06-25 11:53 ` [tip: sched/core] sched: Force the address order of each sched class descriptor tip-bot2 for Steven Rostedt (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219135350.GA2844@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox