The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Kirill Tkhai <ktkhai@virtuozzo.com>
To: Alexander Monakov <amonakov@ispras.ru>
Cc: Peter Zijlstra <peterz@infradead.org>,
	gcc-help@gcc.gnu.org, mingo@redhat.com, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	linux-kernel@vger.kernel.org, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [Q] ld: Does LTO reorder ro variables in two files?
Date: Thu, 19 Dec 2019 19:08:50 +0300	[thread overview]
Message-ID: <f8ecf41d-2f0e-1c17-8c71-1956ca8cf465@virtuozzo.com> (raw)
In-Reply-To: <alpine.LNX.2.20.13.1912191817440.18668@monopod.intra.ispras.ru>

On 19.12.2019 18:45, Alexander Monakov wrote:
> [adding Jan Hubicka, GCC LTO maintainer]
> 
> On Thu, 19 Dec 2019, Kirill Tkhai wrote:
> 
>> CC: gcc-help@gcc.gnu.org
>>
>> Hi, gcc guys,
>>
>> this thread starts here: https://lkml.org/lkml/2019/12/19/403
>>
>> There are two const variables:
>>
>>    struct sched_class idle_sched_class
>> and
>>    struct sched_class fair_sched_class,
>>
>> which are declared in two files idle.c and fair.c.
>>
>> 1)In Makefile the order is: idle.o fair.o
>> 2)the variables go to the same ro section
>> 3)there is no SORT(.*) keyword in linker script.
>>
>> Is it always true, that after linkage &idle_sched_class < &fair_sched_class?
> 
> No, with LTO you don't have that guarantee. For functions it's more obvious,
> GCC wants to analyze functions in reverse topological order so callees are
> generally optimized before callers, and it will emit assembly as it goes, so
> function ordering with LTO does not give much care to translation unit
> boundaries. For variables it's a bit more subtle, GCC partitions all variables
> and functions so it can hand them off to multiple compiler processes while doing
> LTO. There's no guarantees about order of variables that end up in different
> partitions.
> 
> There's __attribute__((no_reorder)) that is intended to enforce ordering even
> with LTO (it's documented under "Common function attributes" but works for
> global variables as well).

Thanks, Alexander!

Kirill

  reply	other threads:[~2019-12-19 16:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 12:39 [PATCH RFC] sched: Micro optimization in pick_next_task() and in check_preempt_curr() Kirill Tkhai
2019-12-19 13:12 ` Peter Zijlstra
2019-12-19 14:02   ` Peter Zijlstra
2019-12-19 14:25     ` Kirill Tkhai
2019-12-19 14:31       ` Kirill Tkhai
2019-12-19 14:43       ` Steven Rostedt
2019-12-19 14:46         ` Kirill Tkhai
2019-12-19 14:59           ` Steven Rostedt
2019-12-19 15:20             ` [PATCH v2] " Kirill Tkhai
2019-12-19 15:40               ` Steven Rostedt
2019-12-19 16:08                 ` Kirill Tkhai
2019-12-19 16:22                   ` Steven Rostedt
2019-12-19 20:16                     ` Kirill Tkhai
2019-12-19 20:20                       ` Steven Rostedt
2019-12-19 16:05               ` Steven Rostedt
2019-12-19 14:04   ` [Q] ld: Does LTO reorder ro variables in two files? Kirill Tkhai
2019-12-19 15:21     ` Jeff Law
2019-12-19 15:30       ` Kirill Tkhai
2019-12-19 15:45     ` Alexander Monakov
2019-12-19 16:08       ` Kirill Tkhai [this message]
2019-12-19 13:50 ` [PATCH RFC] sched: Micro optimization in pick_next_task() and in check_preempt_curr() Steven Rostedt
2019-12-19 13:53   ` Kirill Tkhai
2019-12-19 13:53   ` Peter Zijlstra
2020-06-25 11:53 ` [tip: sched/core] sched: Force the address order of each sched class descriptor tip-bot2 for Steven Rostedt (VMware)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8ecf41d-2f0e-1c17-8c71-1956ca8cf465@virtuozzo.com \
    --to=ktkhai@virtuozzo.com \
    --cc=amonakov@ispras.ru \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=gcc-help@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox