* [PATCH] locking/qspinlock: Fix inaccessible URL of MCS lock paper @ 2019-12-23 2:25 Waiman Long 2020-01-07 12:58 ` Peter Zijlstra 0 siblings, 1 reply; 5+ messages in thread From: Waiman Long @ 2019-12-23 2:25 UTC (permalink / raw) To: Peter Zijlstra, Ingo Molnar, Will Deacon; +Cc: linux-kernel, Waiman Long It turns out that the URL of the MCS lock paper listed in the source code is no longer accessible. I did got question about where the paper was. This patch updates the URL to one that is still accessible. Signed-off-by: Waiman Long <longman@redhat.com> --- kernel/locking/qspinlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c index 2473f10c6956..1d008d2333c0 100644 --- a/kernel/locking/qspinlock.c +++ b/kernel/locking/qspinlock.c @@ -34,7 +34,7 @@ * MCS lock. The paper below provides a good description for this kind * of lock. * - * http://www.cise.ufl.edu/tr/DOC/REP-1992-71.pdf + * https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf * * This queued spinlock implementation is based on the MCS lock, however to make * it fit the 4 bytes we assume spinlock_t to be, and preserve its existing -- 2.18.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] locking/qspinlock: Fix inaccessible URL of MCS lock paper 2019-12-23 2:25 [PATCH] locking/qspinlock: Fix inaccessible URL of MCS lock paper Waiman Long @ 2020-01-07 12:58 ` Peter Zijlstra 2020-01-07 13:09 ` Peter Zijlstra 0 siblings, 1 reply; 5+ messages in thread From: Peter Zijlstra @ 2020-01-07 12:58 UTC (permalink / raw) To: Waiman Long Cc: Ingo Molnar, Will Deacon, linux-kernel, Thomas Gleixner, Konstantin Ryabitsev On Sun, Dec 22, 2019 at 09:25:32PM -0500, Waiman Long wrote: > It turns out that the URL of the MCS lock paper listed in the source > code is no longer accessible. I did got question about where the paper > was. This patch updates the URL to one that is still accessible. > > Signed-off-by: Waiman Long <longman@redhat.com> > --- > kernel/locking/qspinlock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c > index 2473f10c6956..1d008d2333c0 100644 > --- a/kernel/locking/qspinlock.c > +++ b/kernel/locking/qspinlock.c > @@ -34,7 +34,7 @@ > * MCS lock. The paper below provides a good description for this kind > * of lock. > * > - * http://www.cise.ufl.edu/tr/DOC/REP-1992-71.pdf > + * https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf Do we want to stick a copy of the paper in our bugzilla and link that instead? ISTR we do something similar elsewhere, but I'm having trouble finding it. Thomas, Konstantin? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] locking/qspinlock: Fix inaccessible URL of MCS lock paper 2020-01-07 12:58 ` Peter Zijlstra @ 2020-01-07 13:09 ` Peter Zijlstra 2020-01-07 14:14 ` Waiman Long 0 siblings, 1 reply; 5+ messages in thread From: Peter Zijlstra @ 2020-01-07 13:09 UTC (permalink / raw) To: Waiman Long Cc: Ingo Molnar, Will Deacon, linux-kernel, Thomas Gleixner, Konstantin Ryabitsev, Borislav Petkov On Tue, Jan 07, 2020 at 01:58:24PM +0100, Peter Zijlstra wrote: > On Sun, Dec 22, 2019 at 09:25:32PM -0500, Waiman Long wrote: > > It turns out that the URL of the MCS lock paper listed in the source > > code is no longer accessible. I did got question about where the paper > > was. This patch updates the URL to one that is still accessible. > > > > Signed-off-by: Waiman Long <longman@redhat.com> > > --- > > kernel/locking/qspinlock.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c > > index 2473f10c6956..1d008d2333c0 100644 > > --- a/kernel/locking/qspinlock.c > > +++ b/kernel/locking/qspinlock.c > > @@ -34,7 +34,7 @@ > > * MCS lock. The paper below provides a good description for this kind > > * of lock. > > * > > - * http://www.cise.ufl.edu/tr/DOC/REP-1992-71.pdf > > + * https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf > > Do we want to stick a copy of the paper in our bugzilla and link that > instead? ISTR we do something similar elsewhere, but I'm having trouble > finding it. > > Thomas, Konstantin? Boris provided an example from commit: 018ebca8bd70 ("x86/cpufeatures: Enable a new AVX512 CPU feature") That puts a copy of the relevant Intel document here: https://bugzilla.kernel.org/show_bug.cgi?id=204215 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] locking/qspinlock: Fix inaccessible URL of MCS lock paper 2020-01-07 13:09 ` Peter Zijlstra @ 2020-01-07 14:14 ` Waiman Long 2020-01-07 17:23 ` Will Deacon 0 siblings, 1 reply; 5+ messages in thread From: Waiman Long @ 2020-01-07 14:14 UTC (permalink / raw) To: Peter Zijlstra Cc: Ingo Molnar, Will Deacon, linux-kernel, Thomas Gleixner, Konstantin Ryabitsev, Borislav Petkov On 1/7/20 8:09 AM, Peter Zijlstra wrote: > On Tue, Jan 07, 2020 at 01:58:24PM +0100, Peter Zijlstra wrote: >> On Sun, Dec 22, 2019 at 09:25:32PM -0500, Waiman Long wrote: >>> It turns out that the URL of the MCS lock paper listed in the source >>> code is no longer accessible. I did got question about where the paper >>> was. This patch updates the URL to one that is still accessible. >>> >>> Signed-off-by: Waiman Long <longman@redhat.com> >>> --- >>> kernel/locking/qspinlock.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c >>> index 2473f10c6956..1d008d2333c0 100644 >>> --- a/kernel/locking/qspinlock.c >>> +++ b/kernel/locking/qspinlock.c >>> @@ -34,7 +34,7 @@ >>> * MCS lock. The paper below provides a good description for this kind >>> * of lock. >>> * >>> - * http://www.cise.ufl.edu/tr/DOC/REP-1992-71.pdf >>> + * https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf >> Do we want to stick a copy of the paper in our bugzilla and link that >> instead? ISTR we do something similar elsewhere, but I'm having trouble >> finding it. >> >> Thomas, Konstantin? > Boris provided an example from commit: > > 018ebca8bd70 ("x86/cpufeatures: Enable a new AVX512 CPU feature") > > That puts a copy of the relevant Intel document here: > > https://bugzilla.kernel.org/show_bug.cgi?id=204215 > OK, that sounds good. I will put a copy of the paper in the BZ and linked it there. Thanks, Longman ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] locking/qspinlock: Fix inaccessible URL of MCS lock paper 2020-01-07 14:14 ` Waiman Long @ 2020-01-07 17:23 ` Will Deacon 0 siblings, 0 replies; 5+ messages in thread From: Will Deacon @ 2020-01-07 17:23 UTC (permalink / raw) To: Waiman Long Cc: Peter Zijlstra, Ingo Molnar, Will Deacon, linux-kernel, Thomas Gleixner, Konstantin Ryabitsev, Borislav Petkov On Tue, Jan 07, 2020 at 09:14:20AM -0500, Waiman Long wrote: > On 1/7/20 8:09 AM, Peter Zijlstra wrote: > > On Tue, Jan 07, 2020 at 01:58:24PM +0100, Peter Zijlstra wrote: > >> On Sun, Dec 22, 2019 at 09:25:32PM -0500, Waiman Long wrote: > >>> It turns out that the URL of the MCS lock paper listed in the source > >>> code is no longer accessible. I did got question about where the paper > >>> was. This patch updates the URL to one that is still accessible. > >>> > >>> Signed-off-by: Waiman Long <longman@redhat.com> > >>> --- > >>> kernel/locking/qspinlock.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c > >>> index 2473f10c6956..1d008d2333c0 100644 > >>> --- a/kernel/locking/qspinlock.c > >>> +++ b/kernel/locking/qspinlock.c > >>> @@ -34,7 +34,7 @@ > >>> * MCS lock. The paper below provides a good description for this kind > >>> * of lock. > >>> * > >>> - * http://www.cise.ufl.edu/tr/DOC/REP-1992-71.pdf > >>> + * https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf > >> Do we want to stick a copy of the paper in our bugzilla and link that > >> instead? ISTR we do something similar elsewhere, but I'm having trouble > >> finding it. > >> > >> Thomas, Konstantin? > > Boris provided an example from commit: > > > > 018ebca8bd70 ("x86/cpufeatures: Enable a new AVX512 CPU feature") > > > > That puts a copy of the relevant Intel document here: > > > > https://bugzilla.kernel.org/show_bug.cgi?id=204215 > > > OK, that sounds good. I will put a copy of the paper in the BZ and > linked it there. Thanks. When you update the link in the comment, please can you also include the title of the paper. i.e. The paper below ("Algorithms for Scalable Synchronization on Shared-Memory Multiprocessors by Mellor-Crummey and Scott") ... That makes the thing a lot more searchable in case bugzilla is getting DoS'd or whatnot. Will ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-07 17:23 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-12-23 2:25 [PATCH] locking/qspinlock: Fix inaccessible URL of MCS lock paper Waiman Long 2020-01-07 12:58 ` Peter Zijlstra 2020-01-07 13:09 ` Peter Zijlstra 2020-01-07 14:14 ` Waiman Long 2020-01-07 17:23 ` Will Deacon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox