Re: Patch "serial: sprd: Use readable macros instead of magic number" has been added to the 4.19-stable tree

Re: Patch "serial: sprd: Use readable macros instead of magic number" has been added to the 4.19-stable tree

[Greg KH]

On Wed, Jan 01, 2020 at 09:24:05PM -0500, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>     serial: sprd: Use readable macros instead of magic number
> 
> to the 4.19-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      serial-sprd-use-readable-macros-instead-of-magic-num.patch
> and it can be found in the queue-4.19 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 
> 
> 
> commit b8917f323e25835c0ac8d02cba9253bcd79040cf
> Author: Yonghan Ye <yonghan.ye@unisoc.com>
> Date:   Wed Dec 4 20:00:07 2019 +0800
> 
>     serial: sprd: Use readable macros instead of magic number
>     
>     [ Upstream commit 2b5a997386b0594e671a32c7e429cf59ac8fc54c ]
>     
>     Define readable macros instead of magic number to make code more readable.
>     
>     Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>     Acked-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>     Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c
> index 2774af86763e..c6cad45cd34b 100644
> --- a/drivers/tty/serial/sprd_serial.c
> +++ b/drivers/tty/serial/sprd_serial.c
> @@ -294,6 +294,9 @@ static irqreturn_t sprd_handle_irq(int irq, void *dev_id)
>  	if (ims & SPRD_IMSR_TIMEOUT)
>  		serial_out(port, SPRD_ICLR, SPRD_ICLR_TIMEOUT);
>  
> +	if (ims & SPRD_IMSR_BREAK_DETECT)
> +		serial_out(port, SPRD_ICLR, SPRD_IMSR_BREAK_DETECT);
> +
>  	if (ims & (SPRD_IMSR_RX_FIFO_FULL |
>  		SPRD_IMSR_BREAK_DETECT | SPRD_IMSR_TIMEOUT))
>  		sprd_rx(port);

Something went wrong here.  The above patch does not match the
description of the original commit and changelog at all.

I'll go drop this patch from all stable trees now.

thanks,

greg k-h