* [PATCH v2] drm: panfrost: Silence warnings during deferred probe [not found] <CGME20200228094033eucas1p2fa2f6cea3b882e758992d97da2fc50ed@eucas1p2.samsung.com> @ 2020-02-28 9:40 ` Marek Szyprowski 2020-02-28 11:12 ` Daniel Stone ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: Marek Szyprowski @ 2020-02-28 9:40 UTC (permalink / raw) To: dri-devel, linux-kernel Cc: Marek Szyprowski, Rob Herring, Tomeu Vizoso, Steven Price, Alyssa Rosenzweig, Daniel Vetter Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- v2: - fixed build warning --- drivers/gpu/drm/panfrost/panfrost_device.c | 26 +++++++++++++++------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c index 238fb6d54df4..2c4ada3041b1 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -21,7 +21,9 @@ static int panfrost_reset_init(struct panfrost_device *pfdev) pfdev->rstc = devm_reset_control_array_get(pfdev->dev, false, true); if (IS_ERR(pfdev->rstc)) { - dev_err(pfdev->dev, "get reset failed %ld\n", PTR_ERR(pfdev->rstc)); + if (PTR_ERR(pfdev->rstc) != -EPROBE_DEFER) + dev_err(pfdev->dev, "get reset failed %ld\n", + PTR_ERR(pfdev->rstc)); return PTR_ERR(pfdev->rstc); } @@ -44,7 +46,9 @@ static int panfrost_clk_init(struct panfrost_device *pfdev) pfdev->clock = devm_clk_get(pfdev->dev, NULL); if (IS_ERR(pfdev->clock)) { - dev_err(pfdev->dev, "get clock failed %ld\n", PTR_ERR(pfdev->clock)); + if (PTR_ERR(pfdev->clock) != -EPROBE_DEFER) + dev_err(pfdev->dev, "get clock failed %ld\n", + PTR_ERR(pfdev->clock)); return PTR_ERR(pfdev->clock); } @@ -57,8 +61,9 @@ static int panfrost_clk_init(struct panfrost_device *pfdev) pfdev->bus_clock = devm_clk_get_optional(pfdev->dev, "bus"); if (IS_ERR(pfdev->bus_clock)) { - dev_err(pfdev->dev, "get bus_clock failed %ld\n", - PTR_ERR(pfdev->bus_clock)); + if (PTR_ERR(pfdev->bus_clock) != -EPROBE_DEFER) + dev_err(pfdev->dev, "get bus_clock failed %ld\n", + PTR_ERR(pfdev->bus_clock)); return PTR_ERR(pfdev->bus_clock); } @@ -92,7 +97,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev) pfdev->regulator = devm_regulator_get(pfdev->dev, "mali"); if (IS_ERR(pfdev->regulator)) { ret = PTR_ERR(pfdev->regulator); - dev_err(pfdev->dev, "failed to get regulator: %d\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(pfdev->dev, "failed to get regulator: %d\n", + ret); return ret; } @@ -124,19 +131,22 @@ int panfrost_device_init(struct panfrost_device *pfdev) err = panfrost_clk_init(pfdev); if (err) { - dev_err(pfdev->dev, "clk init failed %d\n", err); + if (err != -EPROBE_DEFER) + dev_err(pfdev->dev, "clk init failed %d\n", err); return err; } err = panfrost_regulator_init(pfdev); if (err) { - dev_err(pfdev->dev, "regulator init failed %d\n", err); + if (err != -EPROBE_DEFER) + dev_err(pfdev->dev, "regulator init failed %d\n", err); goto err_out0; } err = panfrost_reset_init(pfdev); if (err) { - dev_err(pfdev->dev, "reset init failed %d\n", err); + if (err != -EPROBE_DEFER) + dev_err(pfdev->dev, "reset init failed %d\n", err); goto err_out1; } -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm: panfrost: Silence warnings during deferred probe 2020-02-28 9:40 ` [PATCH v2] drm: panfrost: Silence warnings during deferred probe Marek Szyprowski @ 2020-02-28 11:12 ` Daniel Stone 2020-02-28 11:41 ` Alyssa Rosenzweig 2020-03-02 15:38 ` Steven Price 2 siblings, 0 replies; 4+ messages in thread From: Daniel Stone @ 2020-02-28 11:12 UTC (permalink / raw) To: Marek Szyprowski Cc: dri-devel, Linux Kernel Mailing List, Rob Herring, Tomeu Vizoso, Steven Price, Alyssa Rosenzweig, Daniel Vetter On Fri, 28 Feb 2020 at 09:40, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Daniel Stone <daniels@collabora.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm: panfrost: Silence warnings during deferred probe 2020-02-28 9:40 ` [PATCH v2] drm: panfrost: Silence warnings during deferred probe Marek Szyprowski 2020-02-28 11:12 ` Daniel Stone @ 2020-02-28 11:41 ` Alyssa Rosenzweig 2020-03-02 15:38 ` Steven Price 2 siblings, 0 replies; 4+ messages in thread From: Alyssa Rosenzweig @ 2020-02-28 11:41 UTC (permalink / raw) To: Marek Szyprowski Cc: dri-devel, linux-kernel, Rob Herring, Tomeu Vizoso, Steven Price, Daniel Vetter [-- Attachment #1: Type: text/plain, Size: 3233 bytes --] Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> On Fri, Feb 28, 2020 at 10:40:26AM +0100, Marek Szyprowski wrote: > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > v2: > - fixed build warning > --- > drivers/gpu/drm/panfrost/panfrost_device.c | 26 +++++++++++++++------- > 1 file changed, 18 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c > index 238fb6d54df4..2c4ada3041b1 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_device.c > +++ b/drivers/gpu/drm/panfrost/panfrost_device.c > @@ -21,7 +21,9 @@ static int panfrost_reset_init(struct panfrost_device *pfdev) > > pfdev->rstc = devm_reset_control_array_get(pfdev->dev, false, true); > if (IS_ERR(pfdev->rstc)) { > - dev_err(pfdev->dev, "get reset failed %ld\n", PTR_ERR(pfdev->rstc)); > + if (PTR_ERR(pfdev->rstc) != -EPROBE_DEFER) > + dev_err(pfdev->dev, "get reset failed %ld\n", > + PTR_ERR(pfdev->rstc)); > return PTR_ERR(pfdev->rstc); > } > > @@ -44,7 +46,9 @@ static int panfrost_clk_init(struct panfrost_device *pfdev) > > pfdev->clock = devm_clk_get(pfdev->dev, NULL); > if (IS_ERR(pfdev->clock)) { > - dev_err(pfdev->dev, "get clock failed %ld\n", PTR_ERR(pfdev->clock)); > + if (PTR_ERR(pfdev->clock) != -EPROBE_DEFER) > + dev_err(pfdev->dev, "get clock failed %ld\n", > + PTR_ERR(pfdev->clock)); > return PTR_ERR(pfdev->clock); > } > > @@ -57,8 +61,9 @@ static int panfrost_clk_init(struct panfrost_device *pfdev) > > pfdev->bus_clock = devm_clk_get_optional(pfdev->dev, "bus"); > if (IS_ERR(pfdev->bus_clock)) { > - dev_err(pfdev->dev, "get bus_clock failed %ld\n", > - PTR_ERR(pfdev->bus_clock)); > + if (PTR_ERR(pfdev->bus_clock) != -EPROBE_DEFER) > + dev_err(pfdev->dev, "get bus_clock failed %ld\n", > + PTR_ERR(pfdev->bus_clock)); > return PTR_ERR(pfdev->bus_clock); > } > > @@ -92,7 +97,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev) > pfdev->regulator = devm_regulator_get(pfdev->dev, "mali"); > if (IS_ERR(pfdev->regulator)) { > ret = PTR_ERR(pfdev->regulator); > - dev_err(pfdev->dev, "failed to get regulator: %d\n", ret); > + if (ret != -EPROBE_DEFER) > + dev_err(pfdev->dev, "failed to get regulator: %d\n", > + ret); > return ret; > } > > @@ -124,19 +131,22 @@ int panfrost_device_init(struct panfrost_device *pfdev) > > err = panfrost_clk_init(pfdev); > if (err) { > - dev_err(pfdev->dev, "clk init failed %d\n", err); > + if (err != -EPROBE_DEFER) > + dev_err(pfdev->dev, "clk init failed %d\n", err); > return err; > } > > err = panfrost_regulator_init(pfdev); > if (err) { > - dev_err(pfdev->dev, "regulator init failed %d\n", err); > + if (err != -EPROBE_DEFER) > + dev_err(pfdev->dev, "regulator init failed %d\n", err); > goto err_out0; > } > > err = panfrost_reset_init(pfdev); > if (err) { > - dev_err(pfdev->dev, "reset init failed %d\n", err); > + if (err != -EPROBE_DEFER) > + dev_err(pfdev->dev, "reset init failed %d\n", err); > goto err_out1; > } > > -- > 2.17.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm: panfrost: Silence warnings during deferred probe 2020-02-28 9:40 ` [PATCH v2] drm: panfrost: Silence warnings during deferred probe Marek Szyprowski 2020-02-28 11:12 ` Daniel Stone 2020-02-28 11:41 ` Alyssa Rosenzweig @ 2020-03-02 15:38 ` Steven Price 2 siblings, 0 replies; 4+ messages in thread From: Steven Price @ 2020-03-02 15:38 UTC (permalink / raw) To: Marek Szyprowski, dri-devel, linux-kernel; +Cc: Tomeu Vizoso, Alyssa Rosenzweig On 28/02/2020 09:40, Marek Szyprowski wrote: > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Steven Price <steven.price@arm.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-02 15:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20200228094033eucas1p2fa2f6cea3b882e758992d97da2fc50ed@eucas1p2.samsung.com>
2020-02-28 9:40 ` [PATCH v2] drm: panfrost: Silence warnings during deferred probe Marek Szyprowski
2020-02-28 11:12 ` Daniel Stone
2020-02-28 11:41 ` Alyssa Rosenzweig
2020-03-02 15:38 ` Steven Price
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox