* [PATCH] arm64: efi: add efi-entry.o to targets instead of extra-$(CONFIG_EFI)
@ 2020-03-05 5:20 Masahiro Yamada
2020-03-05 7:21 ` Ard Biesheuvel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Masahiro Yamada @ 2020-03-05 5:20 UTC (permalink / raw)
To: linux-arm-kernel, Catalin Marinas, Will Deacon
Cc: linux-kernel, Ard Biesheuvel, Masahiro Yamada, James Morse,
Mark Rutland, Torsten Duwe, Vincenzo Frascino
efi-entry.o is built on demand for efi-entry.stub.o, so you do not have
to repeat $(CONFIG_EFI) here. Adding it to 'targets' is enough.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/arm64/kernel/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/Makefile b/arch/arm64/kernel/Makefile
index fc6488660f64..4e5b8ee31442 100644
--- a/arch/arm64/kernel/Makefile
+++ b/arch/arm64/kernel/Makefile
@@ -21,7 +21,7 @@ obj-y := debug-monitors.o entry.o irq.o fpsimd.o \
smp.o smp_spin_table.o topology.o smccc-call.o \
syscall.o
-extra-$(CONFIG_EFI) := efi-entry.o
+targets += efi-entry.o
OBJCOPYFLAGS := --prefix-symbols=__efistub_
$(obj)/%.stub.o: $(obj)/%.o FORCE
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: efi: add efi-entry.o to targets instead of extra-$(CONFIG_EFI)
2020-03-05 5:20 [PATCH] arm64: efi: add efi-entry.o to targets instead of extra-$(CONFIG_EFI) Masahiro Yamada
@ 2020-03-05 7:21 ` Ard Biesheuvel
2020-03-05 9:45 ` Vincenzo Frascino
2020-03-09 18:14 ` Catalin Marinas
2 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2020-03-05 7:21 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-arm-kernel, Catalin Marinas, Will Deacon, Mark Rutland,
Linux Kernel Mailing List, Torsten Duwe, James Morse,
Vincenzo Frascino
On Thu, 5 Mar 2020 at 06:21, Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> efi-entry.o is built on demand for efi-entry.stub.o, so you do not have
> to repeat $(CONFIG_EFI) here. Adding it to 'targets' is enough.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>
> arch/arm64/kernel/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/Makefile b/arch/arm64/kernel/Makefile
> index fc6488660f64..4e5b8ee31442 100644
> --- a/arch/arm64/kernel/Makefile
> +++ b/arch/arm64/kernel/Makefile
> @@ -21,7 +21,7 @@ obj-y := debug-monitors.o entry.o irq.o fpsimd.o \
> smp.o smp_spin_table.o topology.o smccc-call.o \
> syscall.o
>
> -extra-$(CONFIG_EFI) := efi-entry.o
> +targets += efi-entry.o
>
> OBJCOPYFLAGS := --prefix-symbols=__efistub_
> $(obj)/%.stub.o: $(obj)/%.o FORCE
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: efi: add efi-entry.o to targets instead of extra-$(CONFIG_EFI)
2020-03-05 5:20 [PATCH] arm64: efi: add efi-entry.o to targets instead of extra-$(CONFIG_EFI) Masahiro Yamada
2020-03-05 7:21 ` Ard Biesheuvel
@ 2020-03-05 9:45 ` Vincenzo Frascino
2020-03-09 18:14 ` Catalin Marinas
2 siblings, 0 replies; 4+ messages in thread
From: Vincenzo Frascino @ 2020-03-05 9:45 UTC (permalink / raw)
To: Masahiro Yamada, linux-arm-kernel, Catalin Marinas, Will Deacon
Cc: linux-kernel, Ard Biesheuvel, James Morse, Mark Rutland,
Torsten Duwe
On 3/5/20 5:20 AM, Masahiro Yamada wrote:
> efi-entry.o is built on demand for efi-entry.stub.o, so you do not have
> to repeat $(CONFIG_EFI) here. Adding it to 'targets' is enough.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
>
> arch/arm64/kernel/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/Makefile b/arch/arm64/kernel/Makefile
> index fc6488660f64..4e5b8ee31442 100644
> --- a/arch/arm64/kernel/Makefile
> +++ b/arch/arm64/kernel/Makefile
> @@ -21,7 +21,7 @@ obj-y := debug-monitors.o entry.o irq.o fpsimd.o \
> smp.o smp_spin_table.o topology.o smccc-call.o \
> syscall.o
>
> -extra-$(CONFIG_EFI) := efi-entry.o
> +targets += efi-entry.o
>
> OBJCOPYFLAGS := --prefix-symbols=__efistub_
> $(obj)/%.stub.o: $(obj)/%.o FORCE
>
--
Regards,
Vincenzo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: efi: add efi-entry.o to targets instead of extra-$(CONFIG_EFI)
2020-03-05 5:20 [PATCH] arm64: efi: add efi-entry.o to targets instead of extra-$(CONFIG_EFI) Masahiro Yamada
2020-03-05 7:21 ` Ard Biesheuvel
2020-03-05 9:45 ` Vincenzo Frascino
@ 2020-03-09 18:14 ` Catalin Marinas
2 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2020-03-09 18:14 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-arm-kernel, Will Deacon, linux-kernel, Ard Biesheuvel,
James Morse, Mark Rutland, Torsten Duwe, Vincenzo Frascino
On Thu, Mar 05, 2020 at 02:20:52PM +0900, Masahiro Yamada wrote:
> efi-entry.o is built on demand for efi-entry.stub.o, so you do not have
> to repeat $(CONFIG_EFI) here. Adding it to 'targets' is enough.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Queued for 5.7. Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-09 18:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-05 5:20 [PATCH] arm64: efi: add efi-entry.o to targets instead of extra-$(CONFIG_EFI) Masahiro Yamada
2020-03-05 7:21 ` Ard Biesheuvel
2020-03-05 9:45 ` Vincenzo Frascino
2020-03-09 18:14 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox